From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A2E8C6FA90 for ; Wed, 21 Sep 2022 21:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230125AbiIUV1N (ORCPT ); Wed, 21 Sep 2022 17:27:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230137AbiIUV1D (ORCPT ); Wed, 21 Sep 2022 17:27:03 -0400 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [5.144.164.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60115A61C8; Wed, 21 Sep 2022 14:27:02 -0700 (PDT) Received: from [192.168.1.101] (95.49.29.188.neoplus.adsl.tpnet.pl [95.49.29.188]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 9AD6D3F341; Wed, 21 Sep 2022 23:26:58 +0200 (CEST) Message-ID: <13b8c67c-399c-d1a6-4929-61aea27aa57d@somainline.org> Date: Wed, 21 Sep 2022 23:26:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi Content-Language: en-US To: Hector Martin , ~postmarketos/upstreaming@lists.sr.ht Cc: martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Arend van Spriel , Franky Lin , Hante Meuleman , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Linus Walleij , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , Marek Vasut , "Zhao, Jiaqing" , "Russell King (Oracle)" , Soontak Lee , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220921001630.56765-1-konrad.dybcio@somainline.org> <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> From: Konrad Dybcio In-Reply-To: <83b90478-3974-28e6-cf13-35fc4f62e0db@marcan.st> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.09.2022 06:37, Hector Martin wrote: > On 21/09/2022 09.16, Konrad Dybcio wrote: >> Add support for BCM43596 dual-band AC chip, found in >> SONY Xperia X Performance, XZ and XZs smartphones (and >> *possibly* other devices from other manufacturers). >> The chip doesn't require any special handling and seems to work >> just fine OOTB. >> >> PCIe IDs taken from: https://github.com/sonyxperiadev/kernel/commit/9e43fefbac8e43c3d7792e73ca52a052dd86d7e3.patch >> >> Signed-off-by: Konrad Dybcio >> --- >> Changes since v1: >> - rebased the patch against -next >> >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c | 2 ++ >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 4 ++++ >> drivers/net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 4 ++++ >> 3 files changed, 10 insertions(+) >> > [...] >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c >> index f98641bb1528..2e7fc66adf31 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c >> @@ -81,6 +81,7 @@ static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { >> BRCMF_FW_ENTRY(BRCM_CC_43570_CHIP_ID, 0xFFFFFFFF, 43570), >> BRCMF_FW_ENTRY(BRCM_CC_4358_CHIP_ID, 0xFFFFFFFF, 4358), >> BRCMF_FW_ENTRY(BRCM_CC_4359_CHIP_ID, 0xFFFFFFFF, 4359), >> + BRCMF_FW_ENTRY(BRCM_CC_43596_CHIP_ID, 0xFFFFFFFF, 4359), > > So this works with the same firmware as 4359? That sounds a bit off. Is > that really the case? > > brcmfmac4359-pcie isn't in linux-firmware, but presumably there is > *some* semi-canonical firmware you can find for that chip that other > people are already using. If that works on 43596 *and* you plan on using > that firmware or some other firmware marked 4359, then this is fine. If > you are using separate firmware that shipped with a 43596 device and > isn't itself marked 4359, please make it a separate firmware entry. We > can always symlink the firmwares if it later turns out there is no > reason to have different ones for each chip. The firmware that SONY originally gave us for the devices that we know use this chip seems to be marked 4359 [1]. That said, I have no other info about the relation between the two models. [1] https://github.com/sonyxperiadev/device-sony-kagura/tree/q-mr1/rootdir/vendor/firmware Konrad > > - Hector