From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934732AbdACIne (ORCPT ); Tue, 3 Jan 2017 03:43:34 -0500 Received: from mail-lf0-f50.google.com ([209.85.215.50]:36035 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934679AbdACInZ (ORCPT ); Tue, 3 Jan 2017 03:43:25 -0500 Subject: Re: [PATCH v6 05/14] ACPI: platform-msi: retrieve dev id from IORT To: Hanjun Guo , Marc Zyngier , "Rafael J. Wysocki" , Lorenzo Pieralisi References: <1483363905-2806-1-git-send-email-hanjun.guo@linaro.org> <1483363905-2806-6-git-send-email-hanjun.guo@linaro.org> Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, Thomas Gleixner , Greg KH , Ma Jun , Kefeng Wang , Agustin Vega-Frias , Sinan Kaya , charles.garcia-tobin@arm.com, huxinwei@huawei.com, yimin@huawei.com, Jon Masters From: Tomasz Nowicki Message-ID: <13cb0c87-e1c0-c4d6-4793-a3edd20944dc@semihalf.com> Date: Tue, 3 Jan 2017 09:43:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483363905-2806-6-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02.01.2017 14:31, Hanjun Guo wrote: > For devices connecting to ITS, it needs dev id to identify > itself, and this dev id is represented in the IORT table in > named componant node [1] for platform devices, so in this > patch we will scan the IORT to retrieve device's dev id. > > Introduce iort_pmsi_get_dev_id() with pointer dev passed > in for that purpose. > > [1]: https://static.docs.arm.com/den0049/b/DEN0049B_IO_Remapping_Table.pdf > > Signed-off-by: Hanjun Guo > Tested-by: Sinan Kaya > Tested-by: Majun > Tested-by: Xinwei Kong > Cc: Marc Zyngier > Cc: Lorenzo Pieralisi > Cc: Tomasz Nowicki > Cc: Thomas Gleixner > --- > drivers/acpi/arm64/iort.c | 26 ++++++++++++++++++++++++++ > drivers/irqchip/irq-gic-v3-its-platform-msi.c | 4 +++- > include/linux/acpi_iort.h | 8 ++++++++ > 3 files changed, 37 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 174e983..ab7bae7 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -444,6 +444,32 @@ u32 iort_msi_map_rid(struct device *dev, u32 req_id) > } > > /** > + * iort_pmsi_get_dev_id() - Get the device id for a device > + * @dev: The device for which the mapping is to be done. > + * @dev_id: The device ID found. > + * > + * Returns: 0 for successful find a dev id, errors otherwise > + */ > +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id) > +{ > + struct acpi_iort_node *node; > + > + if (!iort_table) > + return -ENODEV; > + > + node = iort_find_dev_node(dev); > + if (!node) { > + dev_err(dev, "can't find related IORT node\n"); > + return -ENODEV; > + } > + > + if(!iort_node_get_id(node, dev_id, IORT_MSI_TYPE, 0)) > + return -ENODEV; > + > + return 0; > +} > + > +/** Giving that you are extending this to NC-> SMMU->ITS case in later patch, we can use existing helpers from iort.c, like that: +/** + * iort_pmsi_get_dev_id() - Get the device id for a device + * @dev: The device for which the mapping is to be done. + * @dev_id: The device ID found. + * + * Returns: 0 for successful find a dev id, errors otherwise + */ +int iort_pmsi_get_dev_id(struct device *dev, u32 *dev_id) +{ + struct acpi_iort_node *node; + + node = iort_find_dev_node(dev); + if (!node) + return -ENODEV; + + if (!iort_node_map_rid(node, 0, dev_id, IORT_MSI_TYPE)) + return -ENODEV; + + return 0; +} Correct me if I am wrong. Tomasz