From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "alan.christopher.jenkins@gmail.com"
<alan.christopher.jenkins@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] block: do not use interruptible wait anywhere
Date: Thu, 12 Apr 2018 17:51:56 +0000 [thread overview]
Message-ID: <13e67e1243ebd96f3f56a150d47444ada47ebde0.camel@wdc.com> (raw)
In-Reply-To: <20180412162321.3671-1-alan.christopher.jenkins@gmail.com>
On Thu, 2018-04-12 at 17:23 +0100, Alan Jenkins wrote:
> @@ -947,14 +946,12 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags)
> */
> smp_rmb();
>
> - ret = wait_event_interruptible(q->mq_freeze_wq,
> + wait_event(q->mq_freeze_wq,
> (atomic_read(&q->mq_freeze_depth) == 0 &&
> (preempt || !blk_queue_preempt_only(q))) ||
> blk_queue_dying(q));
> if (blk_queue_dying(q))
> return -ENODEV;
> - if (ret)
> - return ret;
> }
> }
Hello Alan,
Please reindent the wait_event() arguments such that these remain aligned.
Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
next prev parent reply other threads:[~2018-04-12 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 16:23 [PATCH] block: do not use interruptible wait anywhere Alan Jenkins
2018-04-12 17:51 ` Bart Van Assche [this message]
2018-04-12 18:11 ` [PATCH v2] " Alan Jenkins
2018-04-13 8:31 ` Johannes Thumshirn
2018-04-14 19:46 ` blktest for " Alan Jenkins
2018-04-14 19:52 ` Jens Axboe
2018-04-15 12:15 ` Alan Jenkins
2018-04-14 19:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13e67e1243ebd96f3f56a150d47444ada47ebde0.camel@wdc.com \
--to=bart.vanassche@wdc.com \
--cc=alan.christopher.jenkins@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).