linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: dwalker@fifo99.com
Cc: David Brown <davidb@codeaurora.org>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	Russell King <linux@arm.linux.org.uk>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)
Date: Thu, 15 May 2014 20:10:13 +0200	[thread overview]
Message-ID: <1400177413.11786.11.camel@x220> (raw)
In-Reply-To: <20140515174448.GA31159@fifo99.com>

Daniel,

On Thu, 2014-05-15 at 17:44 +0000, dwalker@fifo99.com wrote:
> On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote:
> > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie.
> > mahimahi)") added just board-mahimahi.c. It did not add
> > board-mahimahi.h, Makefile changes or Kconfig changes.
> > 
> > Four years have passed and this file is still dangling. Remove it.
> > 
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > Untested. But what to test here?
> > 
> I don't mine if Sapphire gets removed,

Could you ACK that patch, please?

>  but I'm working on this one now..

That's good to hear.

>  So I don't want it deleted.

This is not something I get to decide. Nevertheless, given that this
file shouldn't have been merged to begin with, I'd appreciate it if some
deadline could be agreed upon.

That being said, I'm not sure how having just this file in mainline
helps your development efforts. It seems it did receive some updates
for, well, treewide stuff. But it surely didn't get build coverage or
runtime testing. So would you lose much if it only remains in your
development tree?


Paul Bolle


  reply	other threads:[~2014-05-15 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 21:07 [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi) Paul Bolle
2014-05-15 17:44 ` dwalker
2014-05-15 18:10   ` Paul Bolle [this message]
2014-05-15 21:57     ` dwalker
2014-05-19 11:53       ` Paul Bolle
2014-05-19 14:30         ` dwalker
2014-05-20  6:43           ` Ivan T. Ivanov
2014-05-29 18:29     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400177413.11786.11.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).