From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Vitaly Bordug <vbordug@ru.mvista.com>,
Li Yang <leoli@freescale.com>,
Grant Likely <grant.likely@linaro.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Aida Mynzhasova <aida.mynzhasova@skitlab.ru>,
Richard Cochran <richardcochran@gmail.com>,
Claudiu Manoil <claudiu.manoil@freescale.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND...),
linux-kernel@vger.kernel.org (open list),
linuxppc-dev@lists.ozlabs.org (open list:LINUX FOR POWERPC...)
Subject: [PATCH RESEND net-next 6/9] gianfar: use the new fixed PHY helpers
Date: Wed, 21 May 2014 14:38:48 -0700 [thread overview]
Message-ID: <1400708331-18088-7-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1400708331-18088-1-git-send-email-f.fainelli@gmail.com>
of_phy_connect_fixed_link() is becoming obsolete, and also required
platform code to register the fixed PHYs at the specified addresses for
those to be usable. Get rid of it and use the new of_phy_is_fixed_link()
plus of_phy_register_fixed_link() helpers to transition over the new
scheme.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/freescale/gianfar.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index e2d42475b006..282674027c92 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -889,6 +889,17 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev)
priv->phy_node = of_parse_phandle(np, "phy-handle", 0);
+ /* In the case of a fixed PHY, the DT node associated
+ * to the PHY is the Ethernet MAC DT node.
+ */
+ if (of_phy_is_fixed_link(np)) {
+ err = of_phy_register_fixed_link(np);
+ if (err)
+ goto err_grp_init;
+
+ priv->phy_node = np;
+ }
+
/* Find the TBI PHY. If it's not there, we don't support SGMII */
priv->tbi_node = of_parse_phandle(np, "tbi-handle", 0);
@@ -1660,9 +1671,6 @@ static int init_phy(struct net_device *dev)
priv->phydev = of_phy_connect(dev, priv->phy_node, &adjust_link, 0,
interface);
- if (!priv->phydev)
- priv->phydev = of_phy_connect_fixed_link(dev, &adjust_link,
- interface);
if (!priv->phydev) {
dev_err(&dev->dev, "could not attach to PHY\n");
return -ENODEV;
--
1.9.1
next prev parent reply other threads:[~2014-05-21 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 21:38 [PATCH RESEND 0/9 net-next] net: of_phy_connect_fixed_link removal Florian Fainelli
2014-05-21 21:38 ` [PATCH RESEND net-next 1/9] Documentation: devicetree: add old and deprecated 'fixed-link' Florian Fainelli
2014-05-21 21:48 ` Sergei Shtylyov
2014-05-21 21:38 ` [PATCH RESEND net-next 2/9] Documentation: devicetree: net: refer to fixed-link.txt Florian Fainelli
2014-05-21 21:38 ` [PATCH RESEND net-next 3/9] net: bcmgenet: use the new fixed PHY helpers Florian Fainelli
2014-05-21 21:38 ` [PATCH RESEND net-next 4/9] net: systemport: " Florian Fainelli
2014-05-21 21:55 ` Sergei Shtylyov
2014-05-21 22:02 ` Florian Fainelli
2014-05-22 17:21 ` Sergei Shtylyov
2014-05-21 21:38 ` [PATCH RESEND net-next 5/9] fs_enet: " Florian Fainelli
2014-05-21 21:58 ` Sergei Shtylyov
2014-05-21 21:38 ` Florian Fainelli [this message]
2014-05-21 21:38 ` [PATCH RESEND net-next 7/9] ucc_geth: " Florian Fainelli
2014-05-21 21:38 ` [PATCH RESEND net-next 8/9] of: mdio: remove of_phy_connect_fixed_link Florian Fainelli
2014-05-21 21:38 ` [PATCH RESEND net-next 9/9] powerpc/fsl: fsl_soc: remove 'fixed-link' parsing code Florian Fainelli
2014-05-22 15:53 ` [PATCH RESEND 0/9 net-next] net: of_phy_connect_fixed_link removal David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400708331-18088-7-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=aida.mynzhasova@skitlab.ru \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
--cc=richardcochran@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).