linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Chaitanya Hazarey <c@24.io>
Cc: gregkh@linuxfoundation.org, chad@dahc.us,
	michael.banken@mathe.stud.uni-erlangen.de,
	dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines
Date: Sun, 25 May 2014 22:05:49 -0700	[thread overview]
Message-ID: <1401080749.519.1.camel@joe-AO725> (raw)
In-Reply-To: <1401080323-11767-1-git-send-email-c@24.io>

On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote:
> Added a blank line after declarations in many places to fix
> the following warning issued by checkpatch.pl:

Unrelated trivial note:

> diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c

> @@ -2802,6 +2813,7 @@ int wdt_time_left(struct bpctl_dev *pbpctl_dev)
>  static int wdt_timer(struct bpctl_dev *pbpctl_dev, int *time_left)
>  {
>  	int ret = 0;
> +
>  	if (pbpctl_dev->bp_caps & WD_CTL_CAP) {
>  		{
>  			if (pbpctl_dev->wdt_status == WDT_STATUS_UNKNOWN)

unnecessary and ugly double brace



  reply	other threads:[~2014-05-26  5:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-26  4:58 [PATCH] Staging: Silicom: bpctl_mod.c & bypass.c: Adding blank lines Chaitanya Hazarey
2014-05-26  5:05 ` Joe Perches [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-26  0:36 Chaitanya Hazarey
2014-05-26  0:51 ` Greg KH
2014-05-26  4:57   ` Chaitanya Hazarey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401080749.519.1.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=c@24.io \
    --cc=chad@dahc.us \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.banken@mathe.stud.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).