linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Georgi Djakov <gdjakov@mm-sol.com>
Cc: galak@codeaurora.org, iivanov@mm-sol.com, arm@kernel.org,
	khilman@linaro.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, olof@lixom.net,
	davidb@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	agross@codeaurora.org, linus.walleij@linaro.org,
	srinivas.kandagatla@linaro.org
Subject: Re: [PATCH] ARM: msm: Update the references to DEBUG_MSM_UARTx
Date: Mon, 26 May 2014 16:58:07 +0200	[thread overview]
Message-ID: <1401116287.6068.15.camel@x220> (raw)
In-Reply-To: <1401112733-23649-1-git-send-email-gdjakov@mm-sol.com>

Hi Georgi,

On Mon, 2014-05-26 at 16:58 +0300, Georgi Djakov wrote:
> The Kconfig options DEBUG_MSM_UART1, DEBUG_MSM_UART2 and DEBUG_MSM_UART3
> are removed, but they are still referenced in arch/arm/mach-msm/io.c
> Fix this by updating the reference to the new Kconfig option.
> 
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>
> ---
>  arch/arm/mach-msm/io.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/mach-msm/io.c b/arch/arm/mach-msm/io.c
> index 34e0947..b042dca 100644
> --- a/arch/arm/mach-msm/io.c
> +++ b/arch/arm/mach-msm/io.c
> @@ -57,8 +57,7 @@ static struct map_desc msm_io_desc[] __initdata = {
>  		.length =   MSM_SHARED_RAM_SIZE,
>  		.type =     MT_DEVICE,
>  	},
> -#if defined(CONFIG_DEBUG_MSM_UART1) || defined(CONFIG_DEBUG_MSM_UART2) || \
> -		defined(CONFIG_DEBUG_MSM_UART3)
> +#if defined(CONFIG_DEBUG_MSM_UART)
>  	{
>  		/* Must be last: virtual and pfn filled in by debug_ll_addr() */
>  		.length = SZ_4K,
> @@ -76,8 +75,7 @@ void __init msm_map_common_io(void)
>  	 * pages are peripheral interface or not.
>  	 */
>  	asm("mcr p15, 0, %0, c15, c2, 4" : : "r" (0));
> -#if defined(CONFIG_DEBUG_MSM_UART1) || defined(CONFIG_DEBUG_MSM_UART2) || \
> -		defined(CONFIG_DEBUG_MSM_UART3)
> +#if defined(CONFIG_DEBUG_MSM_UART)
>  #ifdef CONFIG_MMU
>  	debug_ll_addr(&msm_io_desc[size - 1].pfn,
>  		      &msm_io_desc[size - 1].virtual);

Should I now redo https://lkml.org/lkml/2014/5/15/249 by making the
(outdated) checks in arch/arm/mach-msm/board-trout.c and
arch/arm/mach-msm/board-trout-gpio.c also use CONFIG_DEBUG_MSM_UART?


Paul Bolle


  reply	other threads:[~2014-05-26 14:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 18:42 [GIT PULL] qcom SoC changes for v3.16 Kumar Gala
2014-05-23 20:10 ` Arnd Bergmann
2014-05-26 12:49 ` Paul Bolle
2014-05-26 13:47   ` Georgi Djakov
2014-05-27  6:12     ` Ivan T. Ivanov
2014-05-26 13:48   ` Ivan T. Ivanov
2014-05-26 13:58   ` [PATCH] ARM: msm: Update the references to DEBUG_MSM_UARTx Georgi Djakov
2014-05-26 14:58     ` Paul Bolle [this message]
2014-05-26 15:44       ` Georgi Djakov
2014-05-26 16:37       ` [PATCH v2] " Georgi Djakov
2014-06-19  8:16         ` Paul Bolle
2014-09-04 22:38           ` Paul Bolle
2014-09-05  7:23             ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1401116287.6068.15.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=agross@codeaurora.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=davidb@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=gdjakov@mm-sol.com \
    --cc=iivanov@mm-sol.com \
    --cc=khilman@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).