From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752784AbaEZWPQ (ORCPT ); Mon, 26 May 2014 18:15:16 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:50761 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbaEZWPL (ORCPT ); Mon, 26 May 2014 18:15:11 -0400 From: Alexander Holler To: linux-kernel@vger.kernel.org Cc: linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Alexander Holler Subject: [PATCH 12/27] mtd: nand: sharpsl: show device structure in sysfs Date: Tue, 27 May 2014 00:12:37 +0200 Message-Id: <1401142372-14148-13-git-send-email-holler@ahsoftware.de> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> References: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a common error in nand-drivers which do not set up a parent device for the mtd-device by using a new inline function. Signed-off-by: Alexander Holler --- drivers/mtd/nand/sharpsl.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/mtd/nand/sharpsl.c b/drivers/mtd/nand/sharpsl.c index e81059b..1a9824a 100644 --- a/drivers/mtd/nand/sharpsl.c +++ b/drivers/mtd/nand/sharpsl.c @@ -142,10 +142,7 @@ static int sharpsl_nand_probe(struct platform_device *pdev) /* Get pointer to private data */ this = (struct nand_chip *)(&sharpsl->chip); - /* Link the private data with the MTD structure */ - sharpsl->mtd.priv = this; - sharpsl->mtd.owner = THIS_MODULE; - + mtd_setup_common_members(&sharpsl->mtd, this, pdev); platform_set_drvdata(pdev, sharpsl); /* @@ -178,8 +175,6 @@ static int sharpsl_nand_probe(struct platform_device *pdev) goto err_scan; /* Register the partitions */ - sharpsl->mtd.name = "sharpsl-nand"; - err = mtd_device_parse_register(&sharpsl->mtd, NULL, NULL, data->partitions, data->nr_partitions); if (err) -- 1.8.3.2