From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbaE0G2P (ORCPT ); Tue, 27 May 2014 02:28:15 -0400 Received: from h1446028.stratoserver.net ([85.214.92.142]:59268 "EHLO mail.ahsoftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751441AbaE0G2O (ORCPT ); Tue, 27 May 2014 02:28:14 -0400 From: Alexander Holler To: linux-kernel@vger.kernel.org Cc: linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Alexander Holler Subject: [PATCH 07/27 v2] mtd: nand: gpmi: show device structure in sysfs Date: Tue, 27 May 2014 08:26:19 +0200 Message-Id: <1401171979-3868-1-git-send-email-holler@ahsoftware.de> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> References: <1401142372-14148-1-git-send-email-holler@ahsoftware.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix a common error in nand-drivers which do not set up a parent device for the mtd-device by using a new inline function. Signed-off-by: Alexander Holler --- Changes to v1: add owner to module drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index bb77f75..8ca225c 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -1682,11 +1682,6 @@ static int gpmi_nand_init(struct gpmi_nand_data *this) /* init current chip */ this->current_chip = -1; - /* init the MTD data structures */ - mtd->priv = chip; - mtd->name = "gpmi-nand"; - mtd->owner = THIS_MODULE; - /* init the nand_chip{}, we don't support a 16-bit NAND Flash bus. */ chip->priv = this; chip->select_chip = gpmi_select_chip; @@ -1791,6 +1786,7 @@ static int gpmi_nand_probe(struct platform_device *pdev) if (ret) goto exit_nfc_init; + mtd_setup_common_members(&this->mtd, &this->nand, pdev); ret = gpmi_nand_init(this); if (ret) goto exit_nfc_init; @@ -1819,6 +1815,7 @@ static int gpmi_nand_remove(struct platform_device *pdev) static struct platform_driver gpmi_nand_driver = { .driver = { .name = "gpmi-nand", + .owner = THIS_MODULE, .of_match_table = gpmi_nand_id_table, }, .probe = gpmi_nand_probe, -- 1.8.3.2