From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584AbcFVNiN (ORCPT ); Wed, 22 Jun 2016 09:38:13 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:56110 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbcFVNiL (ORCPT ); Wed, 22 Jun 2016 09:38:11 -0400 From: Arnd Bergmann To: Deepa Dinamani Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, tytso@mit.edu, viro@zeniv.linux.org.uk, y2038@lists.linaro.org, Andreas Dilger , linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 06/24] fs: ext4: Use current_time() for inode timestamps Date: Wed, 22 Jun 2016 15:40:06 +0200 Message-ID: <14013437.bAvQTZLQL2@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466382443-11063-7-git-send-email-deepa.kernel@gmail.com> References: <1466382443-11063-1-git-send-email-deepa.kernel@gmail.com> <1466382443-11063-7-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:IVF0F6oMapbQ+Q8wd4gjZYTsRPoeHStjI9cPZMUQNvZGBsU5taO ldxhqoT6hWwAbQiwZCvXNxeSMXzs2NFYgvbcIxZ73nLs9+vO6yYZhz7j7cFzu6vek4Rz62i CmfzpB3UC0WgEbz4B0cYD7EcL3HLlFQwy3VE4aBM7AARnqxqRj9NCK5FLhskvpU9R6VL+Vq 9gu4i4y/otKIoy0reLxPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:6ZwNbSIkuHI=:5WFbPJTPdFMaWQbzjc5r+1 WsxK1i5RVPlcuz2rrU03P62D69fkSUG7CCn8nFs5+jLVTZ9Ms4xormKDXotb6QgyDwpCATyXj Q4ScoZVKYSE75gK+WdV7ppT6Vgq/4HYeKpCxCaR02eCfqACSz2orUp7L9ECQJjnQqx9g8xFv8 2imRby6Kbu5fNyM9IDLXxGjP9vh2R6zqEsJFqXXOCFplxaFM2EPdySz6XLwTqEM/nH08USbSr pkOeo8wS1jJqc79b5B6xtYgSXtXIpkMd6qLuhGsfs9vLPNipmtnJ9eNL74vu6iIEMVow9TI0H 4GVJR5z4wsBMC6QVBFZfrg62D5O9wsymA+scj5Le/wy1Ce0s155cbcP6XjGKk1b6/Qft/Ibjj MPx79Kle4J57DSV+vXGRnjdUbfOzdtkLLu4+C0th6mwFAAOK3sQzAR0/lNRmSBa/tIk36ix6f IH4POKMHDRXPvq9xS2zqFwZ6/31TDdfnVMZ12feCKBPjkK4OK7zh+aC5woM8mpuKf3w3Dinyu teyKqfHIhy1SXS1RYIIXf/3EnUZOficBsvEdQEunWlJadClemmrNWdD7aJjfMc1mXnUkmzFbV vFCJzG1Cvc1VrSbFbEBFyjhjXW1cDgkvgQWuo7uQmYGh59+sAumyw45HuDqRKjJJoutTUteya E8AQ4ZBpwsPbGB6SpVnC9ST/B2KKBiMbB7yA6Z79GrO0Ko7laefYtL/kHP7xnRBe9beiJEuOT frwRq9K990Hc8PdQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, June 19, 2016 5:27:05 PM CEST Deepa Dinamani wrote: > @@ -3727,6 +3727,7 @@ static int ext4_cross_rename(struct inode *old_dir, struct dentry *old_dentry, > }; > u8 new_file_type; > int retval; > + struct timespec ctime; > > if ((ext4_encrypted_inode(old_dir) || > ext4_encrypted_inode(new_dir)) && > @@ -3829,8 +3830,9 @@ static int ext4_cross_rename(struct inode *old_dir, struct dentry *old_dentry, > * Like most other Unix systems, set the ctime for inodes on a > * rename. > */ > - old.inode->i_ctime = ext4_current_time(old.inode); > - new.inode->i_ctime = ext4_current_time(new.inode); > + ctime = current_time(old.inode); > + old.inode->i_ctime = ctime; > + new.inode->i_ctime = ctime; > ext4_mark_inode_dirty(handle, old.inode); > ext4_mark_inode_dirty(handle, new.inode); > Adding a local variable here looks like it is going to cause us trouble when we change the return type of current_time() to timespec64. I'd write this as new.inode->i_ctime = old.inode->i_ctime; instead. Arnd