linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Nick Krause <xerofoify@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	lisa@xenapiadmin.com,
	Valentina Manea <valentina.manea.m@gmail.com>,
	ben@decadent.org.uk, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc
Date: Thu, 19 Jun 2014 13:51:43 -0700	[thread overview]
Message-ID: <1403211103.2753.8.camel@joe-AO725> (raw)
In-Reply-To: <CAPDOMVhBHa3QqFY+5T+noCxKkffN6Mo0PrN1_1ZRV22RNXUKXg@mail.gmail.com>

On Thu, 2014-06-19 at 16:20 -0400, Nick Krause wrote:
> Hey Guys,
> So Sorry about wasting your time with bad patchs.
> I feel bad about that. I hope this patch is O.K.
> now. :(

It's not.

> > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c
[]
> > @@ -59,7 +58,9 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
> >                         bLastIniPkt = 1;
> >
> >                 }
> > -
> > +               skb  = dev_alloc_skb(frag_length + 4);
> > +               if (!skb)
> > +                       return false;
> >                 skb  = dev_alloc_skb(frag_length + 4);

You're still wasting time and not thoroughly
reading your own patches.

You've duplicated the dev_alloc_skb line.



  reply	other threads:[~2014-06-19 20:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19 20:18 [PATCH] staging: rtl8192 Check for Null return from dev_skb_alloc Nicholas Krause
2014-06-19 20:20 ` Nick Krause
2014-06-19 20:51   ` Joe Perches [this message]
2014-06-19 20:53   ` Joe Perches
2014-06-19 21:12     ` Nick Krause
2014-06-19 21:18 Nicholas Krause
2014-06-20  2:12 ` Nick Krause
2014-06-20  3:46   ` Nick Krause
2014-06-20 16:49 Nicholas Krause
2014-06-20 19:53 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403211103.2753.8.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=ben@decadent.org.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lisa@xenapiadmin.com \
    --cc=valentina.manea.m@gmail.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).