From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757804AbaFYRSL (ORCPT ); Wed, 25 Jun 2014 13:18:11 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:34602 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757490AbaFYRSJ (ORCPT ); Wed, 25 Jun 2014 13:18:09 -0400 X-IronPort-AV: E=Sophos;i="5.01,547,1400050800"; d="scan'208";a="36502631" Subject: Re: [PATCH] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once From: Eddie Wai To: Maurizio Lombardi CC: Rickard Strandqvist , "James E.J. Bottomley" , , In-Reply-To: <53AADC16.9080301@redhat.com> References: <1403705059-25834-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <53AADC16.9080301@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Wed, 25 Jun 2014 10:13:21 -0700 Message-ID: <1403716401.10214.2.camel@lbirv-waie-lx2.broadcom.com> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-30.el6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-06-25 at 16:26 +0200, Maurizio Lombardi wrote: > Hi, > > On 06/25/2014 04:04 PM, Rickard Strandqvist wrote: > > A struct member variable is set to different values without having used in between. > > > > This was found using a static code analysis program called cppcheck > > > > Signed-off-by: Rickard Strandqvist > > --- > > drivers/scsi/bnx2i/bnx2i_iscsi.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c > > index 166543f..fdf7bc3 100644 > > --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c > > +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c > > @@ -1643,7 +1643,6 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn, > > stats->r2t_pdus = conn->r2t_pdus_cnt; > > stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt; > > stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt; > > - stats->custom_length = 3; > > strcpy(stats->custom[2].desc, "eh_abort_cnt"); > > stats->custom[2].value = conn->eh_abort_cnt; > > stats->digest_err = 0; > > > > Eddie, > > The code modifies the content of stats->custom[2], so shouldn't custom_length be set to 3? > Why is it set to zero at the end of this function? Nice find. This is literally a day1 bug. Yes, I agree that the custom_length should be left at 3. Otherwise, the nlmsg replied back to the application would not have the custom message. Thanks. > > Regards, > Maurizio Lombardi