From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F6BCC433E0 for ; Wed, 13 Jan 2021 03:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1680723134 for ; Wed, 13 Jan 2021 03:40:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726287AbhAMDkM (ORCPT ); Tue, 12 Jan 2021 22:40:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48684 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725988AbhAMDkM (ORCPT ); Tue, 12 Jan 2021 22:40:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610509125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fSaLRoG57KvO7g+HhBEQBIyCeK5sYiN7HkTE57zkReU=; b=WGu/K8aYD7DCrnGN7gDIRGROSZBEJEaOxP47+7gCAvYNsVF2AgL8ilT+1C3VFNcs535MgC YjUZ1aNVoaGNdzzu6EV//KVzUfSxh8FJivhu8opmIsaap8UlF2OCgu8riAOKJJIDCdS+hi 2vNNsj7xw9TAIchRNythflXdJYQF0Po= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-LlhP_UCCPhyJ2DE4Q9BBuA-1; Tue, 12 Jan 2021 22:38:43 -0500 X-MC-Unique: LlhP_UCCPhyJ2DE4Q9BBuA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9D45A805EE3; Wed, 13 Jan 2021 03:38:42 +0000 (UTC) Received: from [10.72.12.205] (ovpn-12-205.pek2.redhat.com [10.72.12.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id F370B60BFA; Wed, 13 Jan 2021 03:38:36 +0000 (UTC) Subject: Re: [PATCH v3] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call To: Cindy Lu , mst@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, lingshan.zhu@intel.com Cc: stable@vger.kernel.org References: <20210112053629.9853-1-lulu@redhat.com> From: Jason Wang Message-ID: <1403c336-4493-255f-54e3-c55dd2015c40@redhat.com> Date: Wed, 13 Jan 2021 11:38:35 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210112053629.9853-1-lulu@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/1/12 下午1:36, Cindy Lu wrote: > In vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa. > this cb.private will finally use in vhost_vdpa_config_cb as > vhost_vdpa. Fix this issue. > > Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa") > Acked-by: Jason Wang > Signed-off-by: Cindy Lu > --- Hi Cindy: I think at least you forget to cc stable. Thanks > drivers/vhost/vdpa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c > index ef688c8c0e0e..3fbb9c1f49da 100644 > --- a/drivers/vhost/vdpa.c > +++ b/drivers/vhost/vdpa.c > @@ -319,7 +319,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp) > struct eventfd_ctx *ctx; > > cb.callback = vhost_vdpa_config_cb; > - cb.private = v->vdpa; > + cb.private = v; > if (copy_from_user(&fd, argp, sizeof(fd))) > return -EFAULT; >