From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F1264436D for ; Wed, 27 Dec 2023 10:43:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="p4lS0a2C" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-40d60a96533so422625e9.1 for ; Wed, 27 Dec 2023 02:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1703673833; x=1704278633; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=psn+iTqR/9XLop+81fIG4XBpTo4yHjFb2NMDUgrpVV0=; b=p4lS0a2C+k12HosYxldW+c9GVcpRQAQYIw4MFI8FtiL6A+P4a3Wb5QBcLx87L15sQg 6TjLLQXdiCk1we2MFcf94VSO4e+uOa8kmr7ONcAqVV4QL2lRPgSNzrdFS678rZz8te2J NvSKA1zEjbczrrBvQ8V7qkhW0kxNsIfj842qekuunJ+UIUzjFE0zrhn/M+Ac25qSiDq9 vTNOcmv3qWGfcsgP9Ox8YLIwCT9c5KB5EY6nQrPwMLv5xkW0wZWqNw4tIz22lZ5/Wc7Z eMVpBylR9eunWFZFNFkXqapc2pZdsmGVcujGXtW3fqdvsDqMOyX7BrvU1tqq0wtLWiNS Z56g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703673833; x=1704278633; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=psn+iTqR/9XLop+81fIG4XBpTo4yHjFb2NMDUgrpVV0=; b=YjOZ86HztndeZvvpTEZ9OboBo71/9VtPU7u2MvMoeEG8qNzVF+dsb2oCcdpKMR0KZ4 9K0mqnx7KHC67JZ/hGq0AbA3rUhtCi291Es88L/0pnSNXqdODxPNPC/9UVbn10Xmy0uy 1E5YGxI3s6IG/TFIyGG40wkAuCPbrAZNToj184kgp6KWoVPD5NHezHoIjrRU28d5VDQW Tou1FggwVAf40xV4GD4/oDUSz8wILDQwJeRpWhLkgw94uzXZJgzhlWsYYSlXOlor1kmx QTDR6qjwvBc+TDzSPUsIsBnfKI4Ae2NKwFRMhAvXImMKepKeH58k/ubqbn8UQwJhpSAJ kUfQ== X-Gm-Message-State: AOJu0YzRXJDp9nkEqX6j3o1zfaOtKSkFWzutc8JTQUaujPmbHbbOtbxt tip/Zml5aZtYmcGRrrJxTzZLUFszsuOsbQ== X-Google-Smtp-Source: AGHT+IEi0hPhVmmuIpcX/7Sf7mfwXdqMNq3yQ1/e7DEySKa1sy84Ci4QVXInPOphq1I56Q3IlsLeOA== X-Received: by 2002:a05:600c:1f17:b0:40d:5c9a:de3b with SMTP id bd23-20020a05600c1f1700b0040d5c9ade3bmr747058wmb.47.1703673832831; Wed, 27 Dec 2023 02:43:52 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.140]) by smtp.gmail.com with ESMTPSA id g8-20020a05600c4ec800b0040d60bd6ce0sm40185wmq.39.2023.12.27.02.43.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Dec 2023 02:43:52 -0800 (PST) Message-ID: <1404c7ee-c9dd-4f2d-8f1d-d87310ceab8e@tuxon.dev> Date: Wed, 27 Dec 2023 12:43:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 1/1] net: ravb: Wait for operation mode to be applied Content-Language: en-US From: claudiu beznea To: Sergey Shtylyov , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, yoshihiro.shimoda.uh@renesas.com, wsa+renesas@sang-engineering.com, mitsuhiro.kimura.kc@renesas.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20231222113552.2049088-1-claudiu.beznea.uj@bp.renesas.com> <20231222113552.2049088-2-claudiu.beznea.uj@bp.renesas.com> <98efc508-c431-2509-5799-96decc124136@omp.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27.12.2023 12:10, claudiu beznea wrote: >>> -static int ravb_config(struct net_device *ndev) >>> +static int ravb_set_opmode(struct net_device *ndev, u32 opmode) >> Since you pass the complete CCC register value below, you should >> rather call the function ravb_set_ccc() and call the parameter opmode >> ccc. > This will be confusing. E.g., if renaming it ravb_set_ccc() one would > expect to set any fields of CCC though this function but this is not true > as ravb_modify() in this function masks only CCC_OPC. The call of: What about ravb_set_opc() or ravb_set_ccc_opc() ?