linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Low <jason.low2@hp.com>
To: Davidlohr Bueso <davidlohr@hp.com>
Cc: a.p.zijlstra@chello.nl, mingo@kernel.org, aswin@hp.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH peterz-queue:locking/core 1/2] locking/rwsem: Fix building with opt spinning and new osq_lock header
Date: Fri, 11 Jul 2014 14:13:35 -0700	[thread overview]
Message-ID: <1405113215.2500.19.camel@j-VirtualBox> (raw)
In-Reply-To: <1405112406-13052-1-git-send-email-davidlohr@hp.com>

On Fri, 2014-07-11 at 14:00 -0700, Davidlohr Bueso wrote:
> Commit 'rwsem: Reduce the size of struct rw_semaphore' broke all
> DECLARE_RWSEM users, ie:
> 
> init/init_task.c:14:44: error: ‘OSQ_UNLOCKED_VA’ undeclared here (not in a function)
> 
> Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>
> ---
>  include/linux/rwsem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
> index 0eff99c..5d40884 100644
> --- a/include/linux/rwsem.h
> +++ b/include/linux/rwsem.h
> @@ -64,7 +64,7 @@ static inline int rwsem_is_locked(struct rw_semaphore *sem)
>  #endif
>  
>  #if defined(CONFIG_SMP) && !defined(CONFIG_RWSEM_GENERIC_SPINLOCK)
> -#define __RWSEM_OPT_INIT(lockname)	, .owner = NULL, .osq = { ATOMIC_INIT(OQS_UNLOCKED_VAL) }
> +#define __RWSEM_OPT_INIT(lockname)	, .owner = NULL, .osq = { ATOMIC_INIT(OSQ_UNLOCKED_VAL) }

Hi David, I'll be sending out a v2 patchset which address Steven's
feedback (which includes using a macro instead of directly initializing
the osq field).

Thanks!



      parent reply	other threads:[~2014-07-11 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 21:00 [PATCH peterz-queue:locking/core 1/2] locking/rwsem: Fix building with opt spinning and new osq_lock header Davidlohr Bueso
2014-07-11 21:00 ` [PATCH peterz-queue:locking/core 2/2] locking/rwsem: Add CONFIG_RWSEM_SPIN_ON_OWNER Davidlohr Bueso
2014-07-16 19:24   ` [tip:locking/urgent] " tip-bot for Davidlohr Bueso
2014-07-11 21:13 ` Jason Low [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405113215.2500.19.camel@j-VirtualBox \
    --to=jason.low2@hp.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aswin@hp.com \
    --cc=davidlohr@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).