From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757650AbaGWPAe (ORCPT ); Wed, 23 Jul 2014 11:00:34 -0400 Received: from gnurou.org ([207.192.72.5]:42638 "EHLO mail.gnurou.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756030AbaGWPAd (ORCPT ); Wed, 23 Jul 2014 11:00:33 -0400 From: Alexandre Courbot To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Courbot Subject: [PATCH] gpio: remove useless check in gpiolib_sysfs_init() Date: Wed, 23 Jul 2014 23:56:53 +0900 Message-Id: <1406127413-10672-1-git-send-email-acourbot@nvidia.com> X-Mailer: git-send-email 2.0.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org An iterator variable cannot be NULL in its loop. Reported-by: Julia Lawall Signed-off-by: Alexandre Courbot --- drivers/gpio/gpiolib-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index 3516502..bcc0ec0 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -814,7 +814,7 @@ static int __init gpiolib_sysfs_init(void) */ spin_lock_irqsave(&gpio_lock, flags); list_for_each_entry(chip, &gpio_chips, list) { - if (!chip || chip->exported) + if (chip->exported) continue; spin_unlock_irqrestore(&gpio_lock, flags); -- 2.0.2