From: "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To: Shane Francis <bigbeeshane@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: "airlied@linux.ie" <airlied@linux.ie>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amd-gfx-request@lists.freedesktop.org"
<amd-gfx-request@lists.freedesktop.org>,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>
Subject: RE: [PATCH v4 2/3] drm/amdgpu: fix scatter-gather mapping with user pages
Date: Wed, 25 Mar 2020 14:00:24 +0000 [thread overview]
Message-ID: <14063C7AD467DE4B82DEDB5C278E8663FFFBD444@fmsmsx107.amr.corp.intel.com> (raw)
In-Reply-To: <20200325090741.21957-3-bigbeeshane@gmail.com>
>-----Original Message-----
>From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
>Shane Francis
>Sent: Wednesday, March 25, 2020 5:08 AM
>To: dri-devel@lists.freedesktop.org
>Cc: airlied@linux.ie; linux-kernel@vger.kernel.org; bigbeeshane@gmail.com;
>amd-gfx-request@lists.freedesktop.org; alexander.deucher@amd.com;
>christian.koenig@amd.com
>Subject: [PATCH v4 2/3] drm/amdgpu: fix scatter-gather mapping with user
>pages
>
>Calls to dma_map_sg may return segments / entries than requested
"may return less segments/entries" ?
^^^
>if they fall on page bounderies. The old implementation did not
>support this use case.
>
>Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>index dee446278417..c6e9885c071f 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>@@ -974,7 +974,7 @@ static int amdgpu_ttm_tt_pin_userptr(struct ttm_tt
>*ttm)
> /* Map SG to device */
> r = -ENOMEM;
> nents = dma_map_sg(adev->dev, ttm->sg->sgl, ttm->sg->nents,
>direction);
>- if (nents != ttm->sg->nents)
>+ if (nents == 0)
> goto release_sg;
this looks correct to me.
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> /* convert SG to linear array of pages and dma addresses */
>--
>2.26.0
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-25 14:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:07 [PATCH v4 0/3] AMDGPU / RADEON / DRM Fix mapping of user pages Shane Francis
2020-03-25 9:07 ` [PATCH v4 1/3] drm/prime: use dma length macro when mapping sg Shane Francis
2020-03-25 13:56 ` Ruhl, Michael J
[not found] ` <CGME20200327075458eucas1p2f1011560c5d2d2a754d2394f56367ebb@eucas1p2.samsung.com>
2020-03-27 7:54 ` [v4,1/3] " Marek Szyprowski
2020-03-27 8:11 ` Christian König
2020-03-27 9:10 ` Marek Szyprowski
2020-03-30 8:18 ` Marek Szyprowski
2020-03-30 9:39 ` Shane Francis
2020-03-30 12:32 ` Shane Francis
2020-03-30 12:34 ` Shane Francis
2020-03-30 13:23 ` Alex Deucher
2020-03-31 5:25 ` Marek Szyprowski
2020-03-31 14:10 ` Alex Deucher
2020-03-31 14:29 ` Marek Szyprowski
[not found] ` <CGME20200327082702eucas1p1a66dd059480c9d02b8f0f3ab225db2c3@eucas1p1.samsung.com>
2020-03-27 8:26 ` Marek Szyprowski
2020-03-25 9:07 ` [PATCH v4 2/3] drm/amdgpu: fix scatter-gather mapping with user pages Shane Francis
2020-03-25 14:00 ` Ruhl, Michael J [this message]
2020-03-25 9:07 ` [PATCH v4 3/3] drm/radeon: " Shane Francis
2020-03-25 14:19 ` Ruhl, Michael J
2020-03-25 15:54 ` Shane Francis
2020-03-25 16:08 ` Alex Deucher
2020-03-25 13:11 ` [PATCH v4 0/3] AMDGPU / RADEON / DRM Fix mapping of " Ruhl, Michael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14063C7AD467DE4B82DEDB5C278E8663FFFBD444@fmsmsx107.amr.corp.intel.com \
--to=michael.j.ruhl@intel.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx-request@lists.freedesktop.org \
--cc=bigbeeshane@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).