From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbaIAClD (ORCPT ); Sun, 31 Aug 2014 22:41:03 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:33978 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752194AbaIACks (ORCPT ); Sun, 31 Aug 2014 22:40:48 -0400 From: Gyungoh Yoo X-Google-Original-From: Gyungoh Yoo To: lgirdwood@gmail.com, broonie@kernel.org Cc: grant.likely@linaro.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Gyungoh Yoo Subject: [PATCH v2.2 1/2] regulator: sky81452: Adding compatible attribute in DT Date: Mon, 1 Sep 2014 11:40:17 +0900 Message-Id: <1409539218-5571-2-git-send-email-jack.yoo@skyworksinc.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1409539218-5571-1-git-send-email-jack.yoo@skyworksinc.com> References: <20140813190423.GI17528@sirena.org.uk> <1409539218-5571-1-git-send-email-jack.yoo@skyworksinc.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adding compatible attriubute in DT. Fixed typo. --- drivers/regulator/sky81452-regulator.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c index 97aff0c..b9c54c6 100644 --- a/drivers/regulator/sky81452-regulator.c +++ b/drivers/regulator/sky81452-regulator.c @@ -68,12 +68,11 @@ static const struct regulator_desc sky81452_reg = { static struct regulator_init_data *sky81452_reg_parse_dt(struct device *dev) { struct regulator_init_data *init_data; - struct device_node *np; + struct device_node *np = of_node_get(dev->of_node); - np = of_get_child_by_name(dev->parent->of_node, "regulator"); - if (unlikely(!np)) { + if (!np) { dev_err(dev, "regulator node not found"); - return NULL; + return ERR_PTR(-ENODATA); } init_data = of_get_regulator_init_data(dev, np); @@ -107,17 +106,28 @@ static int sky81452_reg_probe(struct platform_device *pdev) config.regmap = dev_get_drvdata(dev->parent); rdev = devm_regulator_register(dev, &sky81452_reg, &config); - if (IS_ERR(rdev)) + if (IS_ERR(rdev)) { + dev_err(dev, "failed to register regulator:%d", PTR_ERR(rdev)); return PTR_ERR(rdev); + } platform_set_drvdata(pdev, rdev); return 0; } +#ifdef CONFIG_OF +static const struct of_device_id sky81452_reg_of_match[] = { + { .compatible = "skyworks,sky81452-regulator", }, + { } +}; +MODULE_DEVICE_TABLE(of, sky81452_reg_of_match); +#endif + static struct platform_driver sky81452_reg_driver = { .driver = { .name = "sky81452-regulator", + .of_match_table = of_match_ptr(sky81452_reg_of_match), }, .probe = sky81452_reg_probe, }; @@ -127,4 +137,4 @@ module_platform_driver(sky81452_reg_driver); MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver"); MODULE_AUTHOR("Gyungoh Yoo "); MODULE_LICENSE("GPL"); -MODULE_VERSION("1.0"); +MODULE_VERSION("1.1"); -- 1.9.1