From: Johannes Berg <johannes@sipsolutions.net>
To: Shakil A Khan <shakilk1729@gmail.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net,
linville@tuxdriver.com
Subject: Re: [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized.
Date: Mon, 01 Sep 2014 14:42:22 +0200 [thread overview]
Message-ID: <1409575342.2703.4.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <201409010833.10647.shakilk1729@gmail.com> (sfid-20140901_143315_542502_C9A8C225)
On Mon, 2014-09-01 at 08:33 -0400, Shakil A Khan wrote:
> On Monday 01 September 2014 08:07:38 Johannes Berg wrote:
> > > + u64 wdev_id = 0;
> >
> > it's not used uninitialized, NACK.
> >
> > johannes
> >
>
> wdev_id can be used uninitialized if have_wdev_id turns to be false,
> which may happen if the entry for NL80211_ATTR_WDEV is removed in
> future. Who knows.
In which case the compiler will warn about it. If you were to use a
newer compiler now, you wouldn't see the warning.
johannes
prev parent reply other threads:[~2014-09-01 12:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 11:54 [PATCH 2/2] nl80211.c: Fixed the wdev_id being used uninitialized Shakil A Khan
2014-09-01 12:07 ` Johannes Berg
2014-09-01 12:33 ` Shakil A Khan
2014-09-01 12:42 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409575342.2703.4.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=shakilk1729@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).