From: Paul Bolle <pebolle@tiscali.nl>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Sander Nemvalts <snemvalts@gmail.com>,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Drivers:firewire: fix style errors in core-card.c This is a patch in the core-card.c file which fixes up 2 warnings found by the checkpatch.pl tool Signed-off-by: Sander Nemvalts <snemvalts@gmail.com>
Date: Tue, 02 Sep 2014 00:17:53 +0200 [thread overview]
Message-ID: <1409609873.5546.13.camel@x220> (raw)
In-Reply-To: <20140901235605.5466b6a6@kant>
Quite a crowded subject line!
On Mon, 2014-09-01 at 23:56 +0200, Stefan Richter wrote:
> On Sep 01 Sander Nemvalts wrote:
> > @@ -132,7 +133,7 @@ static void generate_config_rom(struct fw_card *card, __be32 *config_rom)
> > j = 7 + descriptor_count;
> >
> > /* Generate root directory entries for descriptors. */
> > - list_for_each_entry (desc, &descriptor_list, link) {
> > + list_for_each_entry(desc, &descriptor_list, link) {
> > if (desc->immediate > 0)
> > config_rom[i++] = cpu_to_be32(desc->immediate);
> > config_rom[i] = cpu_to_be32(desc->key | (j - i));
>
> We are writing
> for (a; b; c);
> not
> for(a; b; c);
> and thus a space after list_for_each and friends makes sense.
$ git grep "list_for_each_entry (" | wc -l
52
$ git grep "list_for_each_entry(" | wc -l
5991
So "list_for_each_entry(" (without space) seems to be the preferred
style.
Paul Bolle
next prev parent reply other threads:[~2014-09-01 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 18:48 [PATCH] Drivers:firewire: fix style errors in core-card.c This is a patch in the core-card.c file which fixes up 2 warnings found by the checkpatch.pl tool Signed-off-by: Sander Nemvalts <snemvalts@gmail.com> Sander Nemvalts
2014-09-01 21:56 ` Stefan Richter
2014-09-01 22:17 ` Paul Bolle [this message]
[not found] ` <CAAagr2=oG7dyKMBW0DZAJLDoW+2k=vFYADv-JVC6Q2sr7tEYcQ@mail.gmail.com>
2014-09-02 13:18 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409609873.5546.13.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=snemvalts@gmail.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).