From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
llvm@lists.linux.dev
Subject: [PATCH 01/10] media: cx25821: drop duplicated i2c_slave_did_ack()
Date: Mon, 22 Nov 2021 09:26:03 +0000 [thread overview]
Message-ID: <140dfc36fbd3b759a47e972774b362894f43911f.1637573097.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1637573097.git.mchehab+huawei@kernel.org>
This function is defined twice, one at cx25821-i2c and the other
inside cx25821-core. It turns that only the first
is actually used inside the code.
This causes a clang warning.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/10] at: https://lore.kernel.org/all/cover.1637573097.git.mchehab+huawei@kernel.org/
drivers/media/pci/cx25821/cx25821-core.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/media/pci/cx25821/cx25821-core.c b/drivers/media/pci/cx25821/cx25821-core.c
index 40c10ca94def..3078a39f0b95 100644
--- a/drivers/media/pci/cx25821/cx25821-core.c
+++ b/drivers/media/pci/cx25821/cx25821-core.c
@@ -337,13 +337,6 @@ static int cx25821_risc_decode(u32 risc)
return incr[risc >> 28] ? incr[risc >> 28] : 1;
}
-static inline int i2c_slave_did_ack(struct i2c_adapter *i2c_adap)
-{
- struct cx25821_i2c *bus = i2c_adap->algo_data;
- struct cx25821_dev *dev = bus->dev;
- return cx_read(bus->reg_stat) & 0x01;
-}
-
static void cx25821_registers_init(struct cx25821_dev *dev)
{
u32 tmp;
--
2.33.1
next prev parent reply other threads:[~2021-11-22 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 9:26 [PATCH 00/10] Address some clang W=1 warnings Mauro Carvalho Chehab
2021-11-22 9:26 ` Mauro Carvalho Chehab [this message]
2021-11-22 9:26 ` [PATCH 02/10] media: ivtv: drop an unused macro Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 03/10] media: cx18: " Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 04/10] media: stb6100: mark a currently unused function as such Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 05/10] media: mc: mark a debug function with __maybe_unused Mauro Carvalho Chehab
2021-11-22 9:57 ` Laurent Pinchart
2021-11-22 9:26 ` [PATCH 06/10] media: dvb-core: dvb_frontend: address some clang warnings Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 07/10] media: cx25840: drop some unused inline functions Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 08/10] media: marvell-ccic: drop to_cam() unused function Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 09/10] media: omap3isp: mark isp_isr_dbg as __maybe_unused Mauro Carvalho Chehab
2021-11-22 9:58 ` Laurent Pinchart
2021-11-29 7:58 ` [PATCH v2 09/10] media: mc: drop an unused debug function Mauro Carvalho Chehab
2021-11-22 9:26 ` [PATCH 10/10] media: omap3isp: avoid warnings at IS_OUT_OF_BOUNDS() Mauro Carvalho Chehab
2021-11-22 10:04 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140dfc36fbd3b759a47e972774b362894f43911f.1637573097.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=llvm@lists.linux.dev \
--cc=mauro.chehab@huawei.com \
--cc=mchehab@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).