From: Johannes Berg <johannes@sipsolutions.net>
To: Sanjeev Sharma <sanjeev_sharma@mentor.com>
Cc: dsd@gentoo.org, kune@deine-taler.de,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held()
Date: Thu, 11 Sep 2014 12:12:25 +0200 [thread overview]
Message-ID: <1410430345.22863.0.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1410430179-19944-1-git-send-email-sanjeev_sharma@mentor.com> (sfid-20140911_121019_335368_163BEA7C)
On Thu, 2014-09-11 at 15:39 +0530, Sanjeev Sharma wrote:
> on some architecture spin_is_locked() always return false in
> uniprocessor configuration and therefore it would be advise
> to replace with lockdep_assert_held().
>
> Signed-off-by: Sanjeev Sharma <Sanjeev_Sharma@mentor.com>
> ---
> Changes in v2:
> - corrected the typo
Now it compiles, but you got the logic wrong.
> +++ b/drivers/net/wireless/zd1211rw/zd_mac.c
> @@ -235,7 +235,7 @@ void zd_mac_clear(struct zd_mac *mac)
> {
> flush_workqueue(zd_workqueue);
> zd_chip_clear(&mac->chip);
> - ZD_ASSERT(!spin_is_locked(&mac->lock));
> + lockdep_assert_held(&mac->lock);
> ZD_MEMCLEAR(mac, sizeof(struct zd_mac));
> }
Look closely at this again.
johannes
next prev parent reply other threads:[~2014-09-11 10:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 7:05 [PATCH] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() Sanjeev Sharma
2014-08-19 6:39 ` Sharma, Sanjeev
2014-08-22 11:31 ` Johannes Berg
2014-08-22 11:40 ` Sharma, Sanjeev
2014-09-11 4:02 ` Sharma, Sanjeev
2014-09-11 6:53 ` Johannes Berg
2014-09-11 10:09 ` [PATCH v2] " Sanjeev Sharma
2014-09-11 10:12 ` Johannes Berg [this message]
2014-09-11 10:36 ` Sharma, Sanjeev
2014-09-11 10:42 ` Johannes Berg
2014-09-15 6:02 ` Julian Calaby
2014-09-30 7:42 ` Sharma, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410430345.22863.0.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sanjeev_sharma@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).