From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754198AbaIKKmd (ORCPT ); Thu, 11 Sep 2014 06:42:33 -0400 Received: from s3.sipsolutions.net ([5.9.151.49]:56176 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752244AbaIKKmb (ORCPT ); Thu, 11 Sep 2014 06:42:31 -0400 Message-ID: <1410432139.22863.10.camel@jlt4.sipsolutions.net> Subject: Re: [PATCH v2] zd1211rw: replace ZD_ASSERT with lockdep_assert_held() From: Johannes Berg To: "Sharma, Sanjeev" Cc: "dsd@gentoo.org" , "kune@deine-taler.de" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Date: Thu, 11 Sep 2014 12:42:19 +0200 In-Reply-To: References: <1410418407.1825.0.camel@jlt4.sipsolutions.net> <1410430179-19944-1-git-send-email-sanjeev_sharma@mentor.com> (sfid-20140911_121019_335368_163BEA7C) <1410430345.22863.0.camel@jlt4.sipsolutions.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.2-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-09-11 at 10:36 +0000, Sharma, Sanjeev wrote: > > - ZD_ASSERT(!spin_is_locked(&mac->lock)); > > + lockdep_assert_held(&mac->lock); > >Look closely at this again. > > I didn't understand where I put wrong logic ? Ok, that's fine. But please send a new patch only when you've understood the logic. johannes