From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755957AbaIQQJA (ORCPT ); Wed, 17 Sep 2014 12:09:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34547 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755347AbaIQQI7 (ORCPT ); Wed, 17 Sep 2014 12:08:59 -0400 Message-ID: <1410970133.15235.29.camel@fourier> Subject: Re: [PATCH 3.13 120/187] ext4: fix ext4_discard_allocated_blocks() if we can't allocate the pa struct From: Kamal Mostafa To: Ben Hutchings Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, "Theodore Ts'o" Date: Wed, 17 Sep 2014 09:08:53 -0700 In-Reply-To: <1410952405.3040.98.camel@decadent.org.uk> References: <1410818997-9432-1-git-send-email-kamal@canonical.com> <1410818997-9432-121-git-send-email-kamal@canonical.com> <1410952405.3040.98.camel@decadent.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-09-17 at 12:13 +0100, Ben Hutchings wrote: > On Mon, 2014-09-15 at 15:08 -0700, Kamal Mostafa wrote: > > 3.13.11.7 -stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Theodore Ts'o > > > > commit 86f0afd463215fc3e58020493482faa4ac3a4d69 upstream. > > > > If there is a failure while allocating the preallocation structure, a > > number of blocks can end up getting marked in the in-memory buddy > > bitmap, and then not getting released. This can result in the > > following corruption getting reported by the kernel: > > > > EXT4-fs error (device sda3): ext4_mb_generate_buddy:758: group 1126, > > 12793 clusters in bitmap, 12729 in gd > > > > In that case, we need to release the blocks using mb_free_blocks(). > > > > Tested: fs smoke test; also demonstrated that with injected errors, > > the file system is no longer getting corrupted > > > > Google-Bug-Id: 16657874 > > > > Signed-off-by: "Theodore Ts'o" > > Signed-off-by: Kamal Mostafa > [...] > > You need to apply commit c99d1e6e83b0 ("ext4: fix BUG_ON in > mb_free_blocks()") along with this. > > Ben. > Ok, that's now queued up for 3.13.11.7 also. Thanks again, Ben. -Kamal