From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
stefan.hengelein@fau.de
Subject: Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python
Date: Mon, 22 Sep 2014 11:06:19 +0200 [thread overview]
Message-ID: <1411376779.11208.51.camel@x220> (raw)
In-Reply-To: <1411375517.6908.10.camel@nebuchadnezzar>
On Mon, 2014-09-22 at 10:45 +0200, Valentin Rothberg wrote:
> On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote:
> > On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote:
> > > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote:
> > > 2) ./lib/Makefile: TEST_MODULE (defined in lib/Kconfig.debug)
> >
> > TEST_MODULE is an awkward name for a Kconfig symbol. My local script has
> > it special cased.
>
> I plan to rename this feature in a future patch, since imho it violates
> the _MODULE suffix for kernel modules.
Probably a good idea. Could you please CC me if you actually do that?
> > > > > +REGEX_FILE_SOURCE = re.compile(r"\.[cSh]$")
> >
> > New observation: this causes the script to skip text files, shell
> > scripts, etc, doesn't it?
>
> Yes. Do you prefer to cover such files?
It seems useful. By now I must have pointed out stale, misspelled, or
simply odd references to Kconfig macros in Documentation and other
non-code files dozens of times. Documentation seems often overlooked
when Kconfig symbols change.
> I just grepped CONFIG_ in
> Documentation and think that covering such could improve the quality
> there too. I will put this into the next version of the patch.
You'll have to think about what to do with defconfig files. (I ignore
them in my local script, but you may want to report oddities in those
too. They are almost all outdated in one way or another.)
Hope this helps,
Paul Bolle
next prev parent reply other threads:[~2014-09-22 9:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 14:15 [PATCH] checkkconfigsymbols.sh: reimplementation in python Valentin Rothberg
2014-09-21 19:39 ` [PATCH v2] " Valentin Rothberg
2014-09-21 19:53 ` [PATCH v3] " Valentin Rothberg
2014-09-21 21:28 ` Paul Bolle
2014-09-22 7:43 ` Valentin Rothberg
2014-09-22 8:24 ` Paul Bolle
2014-09-22 8:45 ` Valentin Rothberg
2014-09-22 9:06 ` Paul Bolle [this message]
2014-09-22 14:58 ` [PATCH v4] " Valentin Rothberg
2014-09-23 16:45 ` Paul Bolle
2014-09-27 12:57 ` [PATCH v5] " Valentin Rothberg
2014-09-27 14:30 ` [PATCH v6] " Valentin Rothberg
2014-09-28 15:55 ` [PATCH v7] " Valentin Rothberg
2014-09-29 10:28 ` Paul Bolle
2014-09-29 12:08 ` Valentin Rothberg
2014-09-29 12:45 ` Paul Bolle
2014-09-29 14:47 ` Michal Marek
2014-09-29 16:21 ` Paul Bolle
2014-09-29 17:05 ` [PATCH v8] " Valentin Rothberg
2014-10-01 14:58 ` Michal Marek
2014-10-04 9:29 ` Valentin Rothberg
2014-10-08 13:39 ` Michal Marek
2014-10-19 15:30 ` Valentin Rothberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1411376779.11208.51.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.hengelein@fau.de \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).