From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368AbaI3Hjn (ORCPT ); Tue, 30 Sep 2014 03:39:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:23072 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbaI3Hjm (ORCPT ); Tue, 30 Sep 2014 03:39:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,625,1406617200"; d="scan'208";a="607415168" From: "Bityutskiy, Artem" To: "richard@nod.at" CC: "dedekind1@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 4/4] UBI: Fastmap: Ensure that only one fastmap work is scheduled Thread-Topic: [PATCH 4/4] UBI: Fastmap: Ensure that only one fastmap work is scheduled Thread-Index: AQHP3Hodei/9zHAohUmCXsE+0dP68ZwZLocAgAALDgA= Date: Tue, 30 Sep 2014 07:39:23 +0000 Message-ID: <1412062762.2379.2.camel@sauron.fi.intel.com> References: <1412029248-22454-1-git-send-email-richard@nod.at> <1412029248-22454-5-git-send-email-richard@nod.at> <1412059523.3904.11.camel@sauron.fi.intel.com> <542A54E4.2060407@nod.at> In-Reply-To: <542A54E4.2060407@nod.at> Reply-To: "Bityutskiy, Artem" Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.72.54] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s8U7dl0X020028 On Tue, 2014-09-30 at 08:59 +0200, Richard Weinberger wrote: > Am 30.09.2014 08:45, schrieb Bityutskiy, Artem: > > On Tue, 2014-09-30 at 00:20 +0200, Richard Weinberger wrote: > >> + spin_lock(&ubi->wl_lock); > >> + ubi->fm_work_scheduled = 0; > >> + spin_unlock(&ubi->wl_lock); > > > > Andrew Morton once said me that if I am protecting an integer change > > like this with a spinlock, I have a problem in my locking design. He was > > right for my particular case. > > > > Integer is changes atomic. The only other thing spinlock adds are the > > barriers. > > I've added the spinlock to have a barrier in any case. Examples of any? -- Best Regards, Artem Bityutskiy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I