From: Joe Perches <joe@perches.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Grant Likely <grant.likely@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] lib: string.c: Added a function strzcpy
Date: Sat, 18 Oct 2014 18:38:55 -0700 [thread overview]
Message-ID: <1413682735.14629.11.camel@perches.com> (raw)
In-Reply-To: <1413669800-6058-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Sun, 2014-10-19 at 00:03 +0200, Rickard Strandqvist wrote:
> Added a function strzcpy which works the same as strncpy,
> but guaranteed to produce the trailing null character.
>
> There are many places in the code where strncpy used although it
> must be zero terminated, and switching to strlcpy is not an option
> because the string must nonetheless be fyld with zero characters.
[]
> diff --git a/lib/string.c b/lib/string.c
[]
> +char *strzcpy(char *dest, const char *src, size_t count)
> +{
> + char *tmp = dest;
> +
> + while (count) {
> + if ((*tmp = *src) != 0)
> + src++;
> + tmp++;
> + count--;
> + }
> +
> + if (dest != tmp)
> + *--tmp = '\0';
> +
> + return dest;
> +}
why not
char *strzcpy(char *dest, const char *src, size_t count)
{
strncpy(dest, src, count)
if (count)
dest[count - 1] = 0; /* or '\0' or whatever */
return dest;
}
maybe use static inline too.
next prev parent reply other threads:[~2014-10-19 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 22:03 [PATCH 1/5] lib: string.c: Added a function strzcpy Rickard Strandqvist
2014-10-19 1:38 ` Joe Perches [this message]
2014-10-19 12:19 ` Rickard Strandqvist
2014-10-19 15:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413682735.14629.11.camel@perches.com \
--to=joe@perches.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).