From: Wenyou Yang <wenyou.yang@atmel.com>
To: <wsa@the-dreams.de>, <ludovic.desroches@atmel.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<nicolas.ferre@atmel.com>, <linux-arm-kernel@lists.infradead.org>,
<wenyou.yang@atmel.com>
Subject: [PATCH 3/3] i2c/at91: adopt pinctrl support
Date: Mon, 20 Oct 2014 11:42:14 +0800 [thread overview]
Message-ID: <1413776535-10123-4-git-send-email-wenyou.yang@atmel.com> (raw)
In-Reply-To: <1413776535-10123-1-git-send-email-wenyou.yang@atmel.com>
Amend the i2c at91 pin controller to optionally take a pin control
handle and set the state of the pins to:
- "default" on boot, resume and before performing an transfer
- "sleep" on suspend()
This should make it possible to optimize energy usage for the pins
both for the suspend/resume cycle
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
drivers/i2c/busses/i2c-at91.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 8f408f8..ed2c382 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/busses/i2c-at91.c
@@ -32,6 +32,7 @@
#include <linux/slab.h>
#include <linux/platform_data/dma-atmel.h>
#include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
#define DEFAULT_TWI_CLK_HZ 100000 /* max 400 Kbits/s */
#define AT91_I2C_TIMEOUT msecs_to_jiffies(100) /* transfer timeout */
@@ -748,6 +749,8 @@ static int at91_twi_probe(struct platform_device *pdev)
u32 phy_addr;
u32 bus_clk_rate;
+ pinctrl_pm_select_default_state(&pdev->dev);
+
dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
if (!dev)
return -ENOMEM;
@@ -850,8 +853,10 @@ static int at91_twi_suspend(struct device *dev)
{
struct at91_twi_dev *twi_dev = dev_get_drvdata(dev);
- if (!pm_runtime_suspended(dev))
+ if (!pm_runtime_suspended(dev)) {
clk_disable_unprepare(twi_dev->clk);
+ pinctrl_pm_select_sleep_state(dev);
+ }
return 0;
}
@@ -862,6 +867,7 @@ static int at91_twi_resume(struct device *dev)
int ret;
if (!pm_runtime_suspended(dev)) {
+ pinctrl_pm_select_default_state(dev);
ret = clk_prepare_enable(twi_dev->clk);
if (ret)
return ret;
@@ -881,6 +887,8 @@ static int at91_twi_runtime_suspend(struct device *dev)
clk_disable_unprepare(twi_dev->clk);
+ pinctrl_pm_select_sleep_state(dev);
+
return 0;
}
@@ -888,6 +896,8 @@ static int at91_twi_runtime_resume(struct device *dev)
{
struct at91_twi_dev *twi_dev = dev_get_drvdata(dev);
+ pinctrl_pm_select_default_state(dev);
+
return clk_prepare_enable(twi_dev->clk);
}
#endif
--
1.7.9.5
next prev parent reply other threads:[~2014-10-20 3:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 3:42 [PATCH 0/3] i2c/at91: add support PM functions Wenyou Yang
2014-10-20 3:42 ` [PATCH 1/3] i2c/at91: add support for runtime PM Wenyou Yang
2014-10-20 12:39 ` Ludovic Desroches
2014-10-20 13:14 ` Ludovic Desroches
2014-10-21 0:56 ` Yang, Wenyou
2014-10-20 3:42 ` [PATCH 2/3] i2c/at91: add support for system PM Wenyou Yang
2014-10-20 12:42 ` Ludovic Desroches
2014-10-20 13:15 ` Ludovic Desroches
2014-10-20 18:15 ` Kevin Hilman
2014-10-21 1:25 ` Yang, Wenyou
2014-10-20 3:42 ` Wenyou Yang [this message]
2014-10-20 12:43 ` [PATCH 3/3] i2c/at91: adopt pinctrl support Ludovic Desroches
2014-10-20 18:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413776535-10123-4-git-send-email-wenyou.yang@atmel.com \
--to=wenyou.yang@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).