From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Jonathan Corbet <corbet@lwn.net>,
Russell King <linux@arm.linux.org.uk>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Michal Simek <michal.simek@xilinx.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v8 1/5] PM / Runtime: Add getter for querying the IRQ safe option
Date: Fri, 31 Oct 2014 15:40:16 +0100 [thread overview]
Message-ID: <1414766416.6537.6.camel@AMDC1943> (raw)
In-Reply-To: <20141031142241.GA17547@amd>
On pią, 2014-10-31 at 15:22 +0100, Pavel Machek wrote:
> On Fri 2014-10-31 10:14:55, Krzysztof Kozlowski wrote:
> > On pon, 2014-10-20 at 11:04 +0200, Krzysztof Kozlowski wrote:
> > > Add a simple getter pm_runtime_is_irq_safe() for querying whether runtime
> > > PM IRQ safe was set or not.
> > >
> > > Various bus drivers implementing runtime PM may use choose to suspend
> > > differently based on IRQ safeness status of child driver (e.g. do not
> > > unprepare the clock if IRQ safe is not set).
> > >
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
> >
> > Rafael, Len, Pavel,
> >
> > Is proposed API ok? Do you have any comments?
> >
> > I'll upload whole patchset to Russell's patch tracking system. However
> > an ack from PM maintainer is probably needed.
>
> I don't like the API. Having callbacks work in different context (irq
> / noirq) based on what another function reports is ugly.
>
> What is the penalty if we always decide callbacks are not IRQ safe?
Then pm_runtime_get_sync() could not be called in atomic context. The
pl330 runtime PM would have to be completely reworked because one
pm_runtime_get_sync() is called in device_issue_pending which cannot
sleep (at least in non preemptible kernels). Probably this can be solved
some way...
Best regards,
Krzysztof
>
> > > --- a/Documentation/power/runtime_pm.txt
> > > +++ b/Documentation/power/runtime_pm.txt
> > > @@ -468,6 +468,10 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h:
> > > - set the power.irq_safe flag for the device, causing the runtime-PM
> > > callbacks to be invoked with interrupts off
> > >
> > > + bool pm_runtime_is_irq_safe(struct device *dev);
> > > + - return true if power.irq_safe flag was set for the device, causing
> > > + the runtime-PM callbacks to be invoked with interrupts off
> > > +
> > > void pm_runtime_mark_last_busy(struct device *dev);
> > > - set the power.last_busy field to the current time
> > >
next prev parent reply other threads:[~2014-10-31 14:40 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 9:04 [PATCH v8 0/5] amba/dma: pl330: add Power Management support Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 1/5] PM / Runtime: Add getter for querying the IRQ safe option Krzysztof Kozlowski
2014-10-31 9:14 ` Krzysztof Kozlowski
2014-10-31 9:29 ` Ulf Hansson
2014-10-31 9:33 ` Russell King - ARM Linux
2014-10-31 9:54 ` Ulf Hansson
2014-10-31 9:33 ` Krzysztof Kozlowski
2014-10-31 14:22 ` Pavel Machek
2014-10-31 14:40 ` Krzysztof Kozlowski [this message]
2014-11-01 0:29 ` Laurent Pinchart
2014-11-03 9:36 ` Krzysztof Kozlowski
2014-11-03 16:27 ` Vinod Koul
2014-11-03 16:59 ` Laurent Pinchart
2014-11-05 14:09 ` Vinod Koul
2014-11-03 17:04 ` Russell King - ARM Linux
2014-11-05 14:04 ` Vinod Koul
2014-11-05 14:54 ` Laurent Pinchart
2014-10-31 23:11 ` Rafael J. Wysocki
2014-10-31 23:04 ` Russell King - ARM Linux
2014-11-01 0:42 ` Rafael J. Wysocki
2014-11-03 8:51 ` Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 2/5] amba: Add helpers for (un)preparing AMBA clock Krzysztof Kozlowski
2014-10-21 8:05 ` Ulf Hansson
2014-10-20 9:04 ` [PATCH v8 3/5] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Krzysztof Kozlowski
2014-11-01 0:45 ` Rafael J. Wysocki
2014-11-01 0:55 ` Russell King - ARM Linux
2014-11-01 1:01 ` Russell King - ARM Linux
2014-11-03 8:36 ` Krzysztof Kozlowski
2014-11-03 10:04 ` Russell King - ARM Linux
2014-11-03 15:41 ` Alan Stern
2014-11-03 15:44 ` Russell King - ARM Linux
2014-11-04 7:59 ` Krzysztof Kozlowski
2014-11-04 1:57 ` Rafael J. Wysocki
2014-11-04 8:01 ` Krzysztof Kozlowski
2014-11-04 9:11 ` Ulf Hansson
2014-11-04 13:59 ` Rafael J. Wysocki
2014-11-04 16:19 ` Ulf Hansson
2014-11-03 17:17 ` Kevin Hilman
2014-10-20 9:04 ` [PATCH v8 4/5] dma: pl330: add Power Management support Krzysztof Kozlowski
2014-10-20 9:04 ` [PATCH v8 5/5] amba: Remove unused amba_pclk_enable/disable macros Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414766416.6537.6.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lars@metafoo.de \
--cc=len.brown@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=michal.simek@xilinx.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).