From: Hugh Kang <hugh.kang@lge.com>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, jonghoon.park@lge.com,
hugh.kang@lge.com
Subject: [PATCH] regulator: adding disable options for regulator-always-on and regulator-boots-on
Date: Mon, 3 Nov 2014 10:26:43 +0900 [thread overview]
Message-ID: <1414978003-20437-1-git-send-email-hugh.kang@lge.com> (raw)
From: "hugh.kang" <hugh.kang@lge.com>
If a regulator is set by always-on option, the regulator will be set forever.
For example, suppose LDO1 is set to always-on at RevA.dts with including of a.dtsi. After that
RevB.dts may wants to include the same a.dtsi but override the LDO1 always-on option. However,
currently there is no way to delete the always-on option, even when we change the LDO1 option value,
the always-on setting is still remains.
Signed-off-by: hugh.kang <hugh.kang@lge.com>
---
drivers/regulator/of_regulator.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index ee5e67b..4178dbd 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -52,7 +52,13 @@ static void of_get_regulation_constraints(struct device_node *np,
constraints->valid_ops_mask |= REGULATOR_CHANGE_CURRENT;
constraints->boot_on = of_property_read_bool(np, "regulator-boot-on");
+ if (of_property_read_bool(np, "regulator-disable-boot-on"))
+ constraints->boot_on = false;
+
constraints->always_on = of_property_read_bool(np, "regulator-always-on");
+ if (of_property_read_bool(np, "regulator-disable-always-on"))
+ constraints->always_on = false;
+
if (!constraints->always_on) /* status change should be possible. */
constraints->valid_ops_mask |= REGULATOR_CHANGE_STATUS;
--
1.8.3.2
next reply other threads:[~2014-11-03 1:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 1:26 Hugh Kang [this message]
2014-11-03 10:00 ` [PATCH] regulator: adding disable options for regulator-always-on and regulator-boots-on Markus Pargmann
2014-11-03 12:03 ` Mark Brown
2014-11-04 8:20 ` Hugh Kang
2014-11-04 14:11 ` Krzysztof Kozłowski
2014-11-04 19:56 ` Mark Brown
2014-11-06 6:39 ` Hugh Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414978003-20437-1-git-send-email-hugh.kang@lge.com \
--to=hugh.kang@lge.com \
--cc=broonie@kernel.org \
--cc=jonghoon.park@lge.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).