From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbaKCKgE (ORCPT ); Mon, 3 Nov 2014 05:36:04 -0500 Received: from cpsmtpb-ews08.kpnxchange.com ([213.75.39.13]:51613 "EHLO cpsmtpb-ews08.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305AbaKCKfZ (ORCPT ); Mon, 3 Nov 2014 05:35:25 -0500 Message-ID: <1415010921.20372.35.camel@x220> Subject: Re: [PATCH 1/1] kconfig: Deletion of unnecessary checks before the function call "sym_calc_value" From: Paul Bolle To: Markus Elfring Cc: "Yann E. MORIN" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, trivial@kernel.org, Coccinelle Date: Mon, 03 Nov 2014 11:35:21 +0100 In-Reply-To: <54568924.5010008@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54568924.5010008@users.sourceforge.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Nov 2014 10:35:21.0904 (UTC) FILETIME=[DEC72B00:01CFF751] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since you use "SF Markus Elfring", this patch should start with: From: Markus Elfring We don't care that you used a sourceforge.net address. Or has SF another meaning? On Sun, 2014-11-02 at 20:42 +0100, SF Markus Elfring wrote: > The sym_calc_value() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. Side note: I guess the coccinelle script you use just skips cases like if (sym) { sym_calc_value(sym); do_foo_bar(): } Or did you filter those manually? > Signed-off-by: Markus Elfring > --- > scripts/kconfig/confdata.c | 6 ++---- > scripts/kconfig/symbol.c | 3 +-- > 2 files changed, 3 insertions(+), 6 deletions(-) > > diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c > index f88d90f..3073cb6 100644 > --- a/scripts/kconfig/confdata.c > +++ b/scripts/kconfig/confdata.c > @@ -262,8 +262,7 @@ int conf_read_simple(const char *name, int def) > goto load; > sym_add_change_count(1); > if (!sym_defconfig_list) { > - if (modules_sym) > - sym_calc_value(modules_sym); > + sym_calc_value(modules_sym); > return 1; > } > > @@ -399,8 +398,7 @@ setsym: > free(line); > fclose(in); > > - if (modules_sym) > - sym_calc_value(modules_sym); > + sym_calc_value(modules_sym); > return 0; > } > > diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c > index 7caabdb..3f7797b 100644 > --- a/scripts/kconfig/symbol.c > +++ b/scripts/kconfig/symbol.c > @@ -447,8 +447,7 @@ void sym_clear_all_valid(void) > for_all_symbols(i, sym) > sym->flags &= ~SYMBOL_VALID; > sym_add_change_count(1); > - if (modules_sym) > - sym_calc_value(modules_sym); > + sym_calc_value(modules_sym); > } > > void sym_set_changed(struct symbol *sym) Please resend with Acked-by: Paul Bolle added. Paul Bolle