From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <mcgrof@suse.com>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
backports@vger.kernel.org, linux-kernel@vger.kernel.org,
yann.morin.1998@free.fr, mmarek@suse.cz, sassmann@kpanic.de
Subject: Re: [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO
Date: Tue, 04 Nov 2014 22:50:50 +0100 [thread overview]
Message-ID: <1415137850.2064.23.camel@sipsolutions.net> (raw)
In-Reply-To: <20141104215002.GF12953@wotan.suse.de>
On Tue, 2014-11-04 at 22:50 +0100, Luis R. Rodriguez wrote:
> On Tue, Nov 04, 2014 at 11:14:52AM +0100, Johannes Berg wrote:
> > On Tue, 2014-11-04 at 00:43 -0800, Luis R. Rodriguez wrote:
> >
> > > - mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files)))
> > > + if bp_prefix not in sym:
> > > + mf.write('compat-$(%s%s) += %s\n' % (bp_prefix, sym, ' '.join(o_files)))
> > > + else:
> > > + mf.write('compat-$(%s) += %s\n' % (sym, ' '.join(o_files)))
> >
> > I don't think these changes are correct, the bp_prefix is needed anyway,
> > and there's no way it could already be. Looks like this comes from a
> > previous attempt where you misunderstood and thought
> > CONFIG_BACKPORT_BACKPORT_... was actually wrong, when in fact it is
> > correct (and would now be CONFIG_BACKPORT_BPAUTO_...)
>
> I did at one point have BACKPORT_BPAUTO_* stuff on the compat/Kconfig for
> the auto stuff but figured that was superfluous. I'll respin with it.
Not sure what you mean? It seems to me you should just drop the changes
like the one I quoted above.
johannes
next prev parent reply other threads:[~2014-11-04 21:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 8:42 [PATCH v1 00/11] backports: add kernel integration support Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 01/11] backports: move legacy and SmPL patch application into helper Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 02/11] backports: extend module_init() module_exit() for built-in Luis R. Rodriguez
2014-11-04 10:02 ` Johannes Berg
2014-11-04 8:42 ` [PATCH v1 03/11] backports: allow for different backport prefix Luis R. Rodriguez
2014-11-04 10:05 ` Johannes Berg
2014-11-04 21:45 ` Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 04/11] backports: replace BACKPORT_PWD with BACKPORT_DIR Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 05/11] backports: use BACKPORT_DIR prefix on kconfig sources Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 06/11] backports: update dependencies map file Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 07/11] backports: split Kconfig into Kconfig.package and Kconfig.sources Luis R. Rodriguez
2014-11-04 8:42 ` [PATCH v1 08/11] backports: move version file generation to run earlier Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 09/11] backports: use Kconfig for backport version information Luis R. Rodriguez
2014-11-04 10:13 ` Johannes Berg
2014-11-04 21:51 ` Luis R. Rodriguez
2014-11-04 23:33 ` Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 10/11] backports: prefix c-file / h-file auto backport with BPAUTO Luis R. Rodriguez
2014-11-04 10:14 ` Johannes Berg
2014-11-04 21:50 ` Luis R. Rodriguez
2014-11-04 21:50 ` Johannes Berg [this message]
2014-11-05 0:21 ` Luis R. Rodriguez
2014-11-05 7:29 ` Johannes Berg
2014-11-05 8:02 ` Luis R. Rodriguez
2014-11-05 8:12 ` Johannes Berg
2014-11-05 8:20 ` Luis R. Rodriguez
2014-11-04 8:43 ` [PATCH v1 11/11] backports: add full kernel integration support Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415137850.2064.23.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=backports@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=mcgrof@suse.com \
--cc=mmarek@suse.cz \
--cc=sassmann@kpanic.de \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).