From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoff@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org, kexec@lists.infradead.org,
Eric Biederman <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH V3] kexec: Add IND_FLAGS macro
Date: Thu, 13 Nov 2014 10:06:45 +1100 [thread overview]
Message-ID: <1415833605.5124.50.camel@kernel.crashing.org> (raw)
In-Reply-To: <1415820588.15847.6.camel@smoke>
On Wed, 2014-11-12 at 11:29 -0800, Geoff Levand wrote:
> Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
> all the possible kexec IND_ kimage_entry indirection flags. Having this
> macro allows for simplified code in the processing of the kexec
> kimage_entry items. Also, remove the local powerpc definition and use
> the generic one.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
> ---
> Hi Ben,
>
> Could you give your ack on this, then I'll try to get it
> merged with my other kexec patches.
>
> Thanks.
>
> -Geoff
>
> arch/powerpc/kernel/machine_kexec_64.c | 2 --
> include/linux/kexec.h | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> index 879b3aa..75652a32 100644
> --- a/arch/powerpc/kernel/machine_kexec_64.c
> +++ b/arch/powerpc/kernel/machine_kexec_64.c
> @@ -96,8 +96,6 @@ int default_machine_kexec_prepare(struct kimage *image)
> return 0;
> }
>
> -#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
> -
> static void copy_segments(unsigned long ind)
> {
> unsigned long entry;
> diff --git a/include/linux/kexec.h b/include/linux/kexec.h
> index 25e039c..b23412c 100644
> --- a/include/linux/kexec.h
> +++ b/include/linux/kexec.h
> @@ -10,6 +10,7 @@
> #define IND_INDIRECTION (1 << IND_INDIRECTION_BIT)
> #define IND_DONE (1 << IND_DONE_BIT)
> #define IND_SOURCE (1 << IND_SOURCE_BIT)
> +#define IND_FLAGS (IND_DESTINATION | IND_INDIRECTION | IND_DONE | IND_SOURCE)
>
> #if !defined(__ASSEMBLY__)
>
next prev parent reply other threads:[~2014-11-12 23:07 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 18:39 [PATCH 0/5] kexec: minor fixups and enhancements Geoff Levand
2014-08-22 18:39 ` [PATCH 3/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-08-25 17:52 ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 1/5] kexec: Fix make headers_check Geoff Levand
2014-08-25 17:22 ` Vivek Goyal
2014-08-30 12:47 ` Paul Bolle
2014-10-06 14:12 ` Paul Bolle
2014-10-06 17:34 ` Geoff Levand
2014-10-06 18:21 ` Paul Bolle
2014-10-06 19:28 ` Geoff Levand
2014-10-06 17:44 ` H. Peter Anvin
2014-08-22 18:39 ` [PATCH 5/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-08-22 18:39 ` [PATCH 4/5] kexec: Add " Geoff Levand
2014-08-25 17:54 ` Vivek Goyal
2014-08-22 18:39 ` [PATCH 2/5] kexec: Simplify conditional Geoff Levand
2014-08-25 17:42 ` Vivek Goyal
2014-08-25 16:59 ` [PATCH 0/5] kexec: minor fixups and enhancements Vivek Goyal
2014-08-26 7:41 ` Dave Young
2014-08-27 0:33 ` Geoff Levand
2014-08-27 0:42 ` Vivek Goyal
2014-10-07 0:21 ` [PATCH V2 0/5] kexec: Minor " Geoff Levand
2014-10-07 0:21 ` [PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro Geoff Levand
2014-10-07 17:52 ` Vivek Goyal
2014-11-12 19:29 ` [PATCH V3] kexec: Add " Geoff Levand
2014-11-12 23:06 ` Benjamin Herrenschmidt [this message]
2014-10-07 0:21 ` [PATCH V22/5] kexec: Simplify conditional Geoff Levand
2014-10-07 0:21 ` [PATCH V21/5] kexec: Fix make headers_check Geoff Levand
2014-10-07 0:21 ` [PATCH V23/5] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-10-07 0:21 ` [PATCH V24/5] kexec: Add IND_FLAGS macro Geoff Levand
2014-10-07 20:26 ` [PATCH V3 4/5] " Geoff Levand
2014-11-13 0:19 ` [PATCH V3 0/4] kexec: minor fixups and enhancements Geoff Levand
2014-11-13 0:19 ` [PATCH V3 3/4] kexec: Add bit definitions for kimage entry flags Geoff Levand
2014-11-13 0:19 ` [PATCH V3 4/4] kexec: Add IND_FLAGS macro Geoff Levand
2014-11-13 0:19 ` [PATCH V3 2/4] kexec: Simplify conditional Geoff Levand
2014-11-13 0:19 ` [PATCH V3 1/4] kexec: Fix make headers_check Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415833605.5124.50.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=ebiederm@xmission.com \
--cc=geoff@infradead.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).