From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Tony Lindgren <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
Felipe Balbi <balbi@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH] tty: serial: serial-omap: depend on !8250_omap
Date: Wed, 26 Nov 2014 23:01:46 +0100 [thread overview]
Message-ID: <1417039306-2384-1-git-send-email-bigeasy@linutronix.de> (raw)
Technically speaking this is not required. If both are enabled then the
Maikefile order says that 8250 one wins, the second is never probed.
If we choose to enable 8250_omap via defconfig then one might get supprised
that his console isn't working anymore since nothing says use ttySx
instead ttyOx.
This patch _tries_ to bring this to the users' attention by not showing
the serial-omap driver once the 8250 one is enabled. So the user might
choose to use the help text which says that this driver (8250_omap)
uses ttySx instead ttyOx.
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
This is my attempt to warn the defconfig user of the defconfig change
(which did not yet happen). Any suggestions?
drivers/tty/serial/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index e71a28b4b94e..1b1bdf946fee 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1125,7 +1125,7 @@ config SERIAL_OF_PLATFORM
config SERIAL_OMAP
tristate "OMAP serial port support"
- depends on ARCH_OMAP2PLUS
+ depends on ARCH_OMAP2PLUS && !SERIAL_8250_OMAP
select SERIAL_CORE
help
If you have a machine based on an Texas Instruments OMAP CPU you
--
2.1.3
next reply other threads:[~2014-11-26 22:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 22:01 Sebastian Andrzej Siewior [this message]
2014-11-29 9:48 ` [PATCH] tty: serial: serial-omap: depend on !8250_omap Sebastian Andrzej Siewior
2014-11-29 17:34 ` Tony Lindgren
2014-12-01 14:09 ` One Thousand Gnomes
2014-12-01 16:38 ` Tony Lindgren
2014-12-01 17:25 ` Sebastian Andrzej Siewior
2014-12-01 17:39 ` Tony Lindgren
2014-12-01 23:13 ` Aaro Koskinen
2014-12-02 1:51 ` Felipe Balbi
2014-12-05 13:51 ` One Thousand Gnomes
2014-12-18 17:47 ` [PATCH] tty: serial: 8250: omap: add ttySx console if the user didn't Sebastian Andrzej Siewior
2015-01-05 21:26 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417039306-2384-1-git-send-email-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).