From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751880AbaKESR2 (ORCPT ); Wed, 5 Nov 2014 13:17:28 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:56519 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbaKESRZ convert rfc822-to-8bit (ORCPT ); Wed, 5 Nov 2014 13:17:25 -0500 From: Laurent Pinchart To: =?ISO-8859-1?Q?S=F6ren?= Brinkmann Cc: Linus Walleij , Michal Simek , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alessandro Rubini , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 2/7] pinctrl: pinconf-generic: Infer map type from DT property Date: Wed, 05 Nov 2014 20:17:38 +0200 Message-ID: <1417202.djDaFURS6d@avalon> User-Agent: KMail/4.12.5 (Linux/3.16.5-gentoo; KDE/4.12.5; x86_64; ; ) In-Reply-To: References: <1415041531-15520-1-git-send-email-soren.brinkmann@xilinx.com> <21124316.ibhe1N9UZS@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sören, On Wednesday 05 November 2014 10:09:35 Sören Brinkmann wrote: > On Wed, 2014-11-05 at 03:56PM +0200, Laurent Pinchart wrote: > > On Monday 03 November 2014 11:05:26 Soren Brinkmann wrote: > > > With the new 'groups' property, the DT parser can infer the map type > > > from the fact whether 'pins' or 'groups' is used to specify the pin > > > group to work on. > > > To maintain backwards compatibitliy with current usage of the DT > > > binding, this is only done when an invalid map type is passed to the > > > parsing function. > > > > The Renesas PFC implements similar bindings with using the vendor-specific > > properties "renesas,pins" and "renesas,groups" (bindings and > > implementation available at > > Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt and > > drivers/pinctrl/sh-pfc/pinctrl.c respectively). > > > > The Renesas implementation is a bit more generic in that it allows both > > pins and groups to be specified in a single subnode. Do you think that > > feature would make sense for pinconf-generic as well ? > > I don't have a use-case for that. I guess if somebody needs this kind of > functionality it could be added later. I would like to avoid blocking > pinctrl-zynq on adding more features here. I'm fine with that, as long as the changes won't require breaking the DT ABI. I don't think they would but I wanted to raise the issue in case I would have missed a potential issue. -- Regards, Laurent Pinchart