From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbaLGMmR (ORCPT ); Sun, 7 Dec 2014 07:42:17 -0500 Received: from smtprelay0085.hostedemail.com ([216.40.44.85]:36290 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752648AbaLGMmO (ORCPT ); Sun, 7 Dec 2014 07:42:14 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1561:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3866:3867:3868:3870:3871:3872:4321:5007:6261:7901:10004:10400:10848:11658:11914:12517:12519:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: salt12_132d16e4c5d10 X-Filterd-Recvd-Size: 1618 Message-ID: <1417956130.31745.27.camel@perches.com> Subject: Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() From: Joe Perches To: Julia Lawall Cc: SF Markus Elfring , Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , LKML , kernel-janitors@vger.kernel.org Date: Sun, 07 Dec 2014 04:42:10 -0800 In-Reply-To: References: <1417731809.2721.17.camel@perches.com> <1417765287.2721.39.camel@perches.com> <1417955413.31745.25.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2014-12-07 at 13:36 +0100, Julia Lawall wrote: > the semantic patch is only using __func__ and only in cases where > the string wanted is similar to the name of the current function, so I > think it should be OK? Yes, it'd be a good thing.