From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, stable@vger.kernel.org
Subject: [PATCH v2] x86/tsc: Change Fast TSC calibration failed from error to warning
Date: Tue, 9 Dec 2014 01:27:50 -0500
Message-ID: <1418106470-6906-1-git-send-email-alexandre.f.demers@gmail.com> (raw)
Most users see this message when booting without knowning that it is of
mostly no importance and that TSC calibration may have succeeded by another
way.
As explained thoroufly by Paul Bolle in 2012
(http://lkml.iu.edu//hypermail/linux/kernel/1209.3/00224.html),
"Fast TSC calibration failed" should not be considered as an error since
other calibration methods are being tried afterward. At most, those send a
warning if they fail (not an error). So let's change the message from error
to warning.
It should also fix bug 75971: fast tsc calibration failed on ubuntu 14.04 LTS
Tested on kernel 3.18.
v2: fixed comment.
Cc: stable@vger.kernel.org
Signed-off-by: Alexandre Demers <alexandre.f.demers@gmail.com>
---
arch/x86/kernel/tsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index b6025f9..5a22022 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -617,7 +617,7 @@ static unsigned long quick_pit_calibrate(void)
goto success;
}
}
- pr_err("Fast TSC calibration failed\n");
+ pr_warn("Fast TSC calibration failed\n");
return 0;
success:
--
2.1.0
next reply index
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 6:27 Alexandre Demers [this message]
2015-01-23 10:00 ` [tip:x86/urgent] x86/tsc: Change Fast TSC calibration failed from error to info tip-bot for Alexandre Demers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418106470-6906-1-git-send-email-alexandre.f.demers@gmail.com \
--to=alexandre.f.demers@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
linux-kernel@vger.kernel.org
public-inbox-index lkml
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git