From: Jeremiah Mahler <jmmahler@gmail.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk
Date: Thu, 11 Dec 2014 15:29:53 -0800 [thread overview]
Message-ID: <1418340594-30469-2-git-send-email-jmmahler@gmail.com> (raw)
In-Reply-To: <1418340594-30469-1-git-send-email-jmmahler@gmail.com>
If a USB serial device (e.g. /dev/ttyUSB0) with an active program is
unplugged, a bunch of -EPROTO (71) error messages will be produced by
usb_serial_generic_read_bulk_callback() as it tries to resubmit the
request.
usb_serial_generic_read_bulk_callback - nonzero urb status: -71
Keep the same functionality, resubmit after an -EPROTO error, but change
message log level to debug instead of error so they are handled quietly
by default.
Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
drivers/usb/serial/generic.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index 1bd1922..98fe718 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -372,6 +372,10 @@ void usb_serial_generic_read_bulk_callback(struct urb *urb)
dev_err(&port->dev, "%s - urb stopped: %d\n",
__func__, urb->status);
return;
+ case -EPROTO:
+ dev_dbg(&port->dev, "%s - urb resubmit: %d\n",
+ __func__, urb->status);
+ goto resubmit;
default:
dev_err(&port->dev, "%s - nonzero urb status: %d\n",
__func__, urb->status);
--
2.1.3
next prev parent reply other threads:[~2014-12-11 23:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 23:29 [PATCH 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Jeremiah Mahler
2014-12-11 23:29 ` Jeremiah Mahler [this message]
2014-12-11 23:29 ` [PATCH 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2014-12-16 11:49 ` Johan Hovold
2014-12-15 10:23 ` [PATCH 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Johan Hovold
2014-12-15 12:53 ` Jeremiah Mahler
2014-12-15 16:38 ` Greg Kroah-Hartman
2014-12-16 7:10 ` Jeremiah Mahler
2014-12-16 11:46 ` Johan Hovold
2014-12-16 11:42 ` Johan Hovold
2014-12-20 9:11 ` [PATCH v2 " Jeremiah Mahler
2014-12-20 9:11 ` [PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Jeremiah Mahler
2014-12-20 12:32 ` Sergei Shtylyov
2014-12-20 12:59 ` Jeremiah Mahler
2014-12-20 16:17 ` [PATCH v2b " Jeremiah Mahler
2014-12-20 9:11 ` [PATCH v2 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 0/2] usb: serial: handle -ENODEV and -EPROTO quietly Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk Jeremiah Mahler
2015-01-11 11:36 ` Johan Hovold
2015-01-11 13:31 ` Jeremiah Mahler
2015-01-11 0:44 ` [RESEND PATCH v2 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 0/2] usb: serial: silence non-critical unplug read errors Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 1/2] usb: serial: silence all non-critical " Jeremiah Mahler
2015-01-11 13:42 ` [PATCH v3 2/2] usb: serial: handle -ENODEV quietly in generic_submit_read_urb Jeremiah Mahler
2015-01-12 9:27 ` [PATCH v3 0/2] usb: serial: silence non-critical unplug read errors Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418340594-30469-2-git-send-email-jmmahler@gmail.com \
--to=jmmahler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).