From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Gavin Guo <gavin.guo@canonical.com>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: General protection fault in iscsi_rx_thread_pre_handler
Date: Thu, 22 Jan 2015 09:35:07 -0800 [thread overview]
Message-ID: <1421948107.30821.2.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <CA+eFSM3H2zO7+bQBd7jO2sjB-MWjGNfGTeqDZDY_8_ruzj_Q_Q@mail.gmail.com>
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
> Hi Nicolas,
>
> On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
> <nab@linux-iscsi.org> wrote:
> > Hi Gavin,
> >
> > On Thu, 2015-01-22 at 06:38 +0800, Gavin Guo wrote:
> >> Hi all,
> >>
> >> The general protection fault screenshot is attached.
> >>
> >> Summary:
> >> The kernel is Ubuntu-3.13.0-39.66. I've done basic analysis and found
> >> the fault is in list_del of iscsi_del_ts_from_active_list. And it
> >> looks like deleting the iscsi_thread_set *ts two times. The point to
> >> delete including iscsi_get_ts_from_inactive_list, was also checked but
> >> still can't find the clue. Really appreciate if anyone can provide any
> >> idea on the bug.
> >>
<SNIP>
> >
> > Thanks for your detailed analysis.
> >
> > A similar bug was reported off-list some months back by a person using
> > iser-target + RoCE export on v3.12.y code. Just to confirm, your
> > environment is using traditional iscsi-target + TCP export, right..?
>
> I am sorry that I'm not an expert of the field and already google RoCE
> on the internet but still don't really know what RoCE is. However, I
> can provide the informations. We used iscsiadm on the initiator side
> and lio_node and tcm_node commands to create the targets for
> connection. I think it should be normal iscsi-target using TCP
> export.
>
Yep, that would be traditional iscsi-target + TCP export.
> >
> > At the time, a different set of iser-target related changes ended up
> > avoiding this issue on his particular setup, so we thought it was likely
> > a race triggered by login failures specific to iser-target code.
> >
> > There was a untested patch (included inline below) to drop the legacy
> > active_ts_list usage all-together, but IIRC he was not able to reproduce
> > further so the patch didn't get picked up for mainline.
> >
> > If your able to reliability reproduce, please try with the following
> > patch and let us know your progress.
>
> Thanks for your time reading the mail. I'll let you know the result.
Just curious, are you able to reliability reproduce this bug in a VM..?
--nab
next prev parent reply other threads:[~2015-01-22 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+eFSM1iir5QYsUALigzwcCPiqDGaNKBVq22unydN+-uTxZD2Q@mail.gmail.com>
[not found] ` <1421920228.7061.48.camel@haakon3.risingtidesystems.com>
2015-01-22 15:56 ` General protection fault in iscsi_rx_thread_pre_handler Gavin Guo
2015-01-22 17:35 ` Nicholas A. Bellinger [this message]
2015-01-23 1:30 ` Gavin Guo
2015-01-30 22:53 ` Nicholas A. Bellinger
2015-02-01 3:47 ` Gavin Guo
2015-02-03 0:28 ` Gavin Guo
2015-02-12 7:16 ` Nicholas A. Bellinger
2015-02-16 10:52 ` Gavin Guo
2015-02-16 10:56 ` Gavin Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421948107.30821.2.camel@haakon3.risingtidesystems.com \
--to=nab@linux-iscsi.org \
--cc=gavin.guo@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).