linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@redhat.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.sf.net,
	Dave Airlie <airlied@redhat.com>
Subject: [PATCH] vt_buffer: drop console buffer copying optimisations
Date: Thu, 29 Jan 2015 14:11:25 +1000	[thread overview]
Message-ID: <1422504685-7864-1-git-send-email-airlied@redhat.com> (raw)

These two copy to/from VGA memory, however on the Silicon
Motion SMI750 VGA card on a 64-bit system cause console corruption.

This is due to the hw being buggy and not handling a 64-bit transaction
correctly.

We could try and create a 32-bit version of these routines,
but I'm not sure the optimisation is worth much today.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1132826

Tested-by: Huawei engineering.
Signed-off-by: Dave Airlie <airlied@redhat.com>
---

Linus, this came up a while back I finally got some confirmation
that it fixes those servers.

 include/linux/vt_buffer.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/vt_buffer.h b/include/linux/vt_buffer.h
index 057db7d..f38c10b 100644
--- a/include/linux/vt_buffer.h
+++ b/include/linux/vt_buffer.h
@@ -21,10 +21,6 @@
 #ifndef VT_BUF_HAVE_RW
 #define scr_writew(val, addr) (*(addr) = (val))
 #define scr_readw(addr) (*(addr))
-#define scr_memcpyw(d, s, c) memcpy(d, s, c)
-#define scr_memmovew(d, s, c) memmove(d, s, c)
-#define VT_BUF_HAVE_MEMCPYW
-#define VT_BUF_HAVE_MEMMOVEW
 #endif
 
 #ifndef VT_BUF_HAVE_MEMSETW
-- 
1.9.3


             reply	other threads:[~2015-01-29  4:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29  4:11 Dave Airlie [this message]
2015-01-29 12:06 ` [PATCH] vt_buffer: drop console buffer copying optimisations Peter Hurley
2015-01-29 23:40 ` Linus Torvalds
2015-01-29 23:57   ` Greg Kroah-Hartman
2015-01-30  0:03     ` Linus Torvalds
2015-01-30  0:14       ` Dave Airlie
2015-02-03 15:54   ` One Thousand Gnomes
2015-02-05  9:01     ` Geert Uytterhoeven
2015-02-05 11:35       ` One Thousand Gnomes
2015-02-09 10:35         ` Daniel Stone
2015-02-09 10:49           ` Geert Uytterhoeven
2015-02-09 11:00             ` Daniel Stone
2015-02-09 20:17               ` One Thousand Gnomes
2015-02-24 16:49 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422504685-7864-1-git-send-email-airlied@redhat.com \
    --to=airlied@redhat.com \
    --cc=dri-devel@lists.sf.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).