From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758924AbbA3Cre (ORCPT ); Thu, 29 Jan 2015 21:47:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53421 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbA3Crd (ORCPT ); Thu, 29 Jan 2015 21:47:33 -0500 Date: Fri, 30 Jan 2015 02:55:10 +0008 From: Jason Wang Subject: Re: [PATCH 2/3] hv: vmbus_post_msg: retry the hypercall on HV_STATUS_INVALID_CONNECTION_ID To: Dexuan Cui Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, kys@microsoft.com, haiyangz@microsoft.com Message-Id: <1422586030.5014.1@smtp.corp.redhat.com> In-Reply-To: <1422529361-28228-1-git-send-email-decui@microsoft.com> References: <1422529361-28228-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 29, 2015 at 7:02 PM, Dexuan Cui wrote: > I got the hypercall error code on Hyper-V 2008 R2 when keeping running > "rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe > hv_utils" > in a Linux guest. > > Without the patch, the driver can occasionally fail to load. > > CC: "K. Y. Srinivasan" > Signed-off-by: Dexuan Cui > --- > arch/x86/include/uapi/asm/hyperv.h | 1 + > drivers/hv/connection.c | 9 +++++++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/x86/include/uapi/asm/hyperv.h > b/arch/x86/include/uapi/asm/hyperv.h > index 90c458e..b9daffb 100644 > --- a/arch/x86/include/uapi/asm/hyperv.h > +++ b/arch/x86/include/uapi/asm/hyperv.h > @@ -225,6 +225,7 @@ > #define HV_STATUS_INVALID_HYPERCALL_CODE 2 > #define HV_STATUS_INVALID_HYPERCALL_INPUT 3 > #define HV_STATUS_INVALID_ALIGNMENT 4 > +#define HV_STATUS_INVALID_CONNECTION_ID 18 > #define HV_STATUS_INSUFFICIENT_BUFFERS 19 > > typedef struct _HV_REFERENCE_TSC_PAGE { > diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c > index c4acd1c..8bd05f3 100644 > --- a/drivers/hv/connection.c > +++ b/drivers/hv/connection.c > @@ -440,6 +440,15 @@ int vmbus_post_msg(void *buffer, size_t buflen) > ret = hv_post_message(conn_id, 1, buffer, buflen); > > switch (ret) { > + case HV_STATUS_INVALID_CONNECTION_ID: > + /* > + * We could get this if we send messages too > + * frequently or the host is under low resource > + * conditions: let's wait 1 more second before > + * retrying the hypercall. > + */ The name HV_STATUS_INVALID_CONNECTION_ID is really confusing in this case. Since it does not show any meaning of lacking resources. > + msleep(1000); > + break; > case HV_STATUS_INSUFFICIENT_BUFFERS: > ret = -ENOMEM; I thought host should return this error value when lacking resources? > > case -ENOMEM: > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/