From: Jiang Liu <jiang.liu@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Yinghai Lu <yinghai@kernel.org>, Borislav Petkov <bp@alien8.de>,
Lv Zheng <lv.zheng@intel.com>, Len Brown <lenb@kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: [Patch v2 09/23] ACPI: Fix a bug in parsing ACPI Memory24 resource
Date: Mon, 2 Feb 2015 10:42:54 +0800 [thread overview]
Message-ID: <1422844988-13854-10-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1422844988-13854-1-git-send-email-jiang.liu@linux.intel.com>
According to ACPI spec 5, section 6.4.3.1 "24-Bit Memory Range Descriptor",
minimum, maximum and address_length field in struct acpi_resource_memory24
is in granularity of 256-bytes. So shift 8-bit left to get correct address.
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
drivers/acpi/resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 7ce00a63f695..5544c6d26f32 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -90,8 +90,8 @@ bool acpi_dev_resource_memory(struct acpi_resource *ares, struct resource *res)
switch (ares->type) {
case ACPI_RESOURCE_TYPE_MEMORY24:
memory24 = &ares->data.memory24;
- acpi_dev_get_memresource(res, memory24->minimum,
- memory24->address_length,
+ acpi_dev_get_memresource(res, memory24->minimum << 8,
+ memory24->address_length << 8,
memory24->write_protect);
break;
case ACPI_RESOURCE_TYPE_MEMORY32:
--
1.7.10.4
next prev parent reply other threads:[~2015-02-02 2:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 2:42 [Patch v2 00/23] Improve ACPI resource parsing interfaces and enable IOAPIC hotplug Jiang Liu
2015-02-02 2:42 ` [Patch v2 01/23] ACPICA: Resources: Provide common part for struct acpi_resource_address structures Jiang Liu
2015-02-02 2:42 ` [Patch v2 02/23] ACPI: Remove redundant check in function acpi_dev_resource_address_space() Jiang Liu
2015-02-02 2:42 ` [Patch v2 03/23] ACPI: Implement proper length checks for mem resources Jiang Liu
2015-02-02 2:42 ` [Patch v2 04/23] ACPI: Use the length check for io resources as well Jiang Liu
2015-02-02 2:42 ` [Patch v2 05/23] ACPI: Let the parser return false for disabled resources Jiang Liu
2015-02-02 2:42 ` [Patch v2 06/23] ACPI: Unify the parsing of address_space and ext_address_space Jiang Liu
2015-02-02 2:42 ` [Patch v2 07/23] ACPI: Move the window flag logic to the combined parser Jiang Liu
2015-02-02 2:42 ` [Patch v2 08/23] ACPI: Add prefetch decoding to the address space parser Jiang Liu
2015-02-02 2:42 ` Jiang Liu [this message]
2015-02-02 2:42 ` [Patch v2 10/23] ACPI: Normalize return value of resource parser functions Jiang Liu
2015-02-02 2:42 ` [Patch v2 11/23] ACPI: Set flag IORESOURCE_UNSET for unassigned resources Jiang Liu
2015-02-02 2:42 ` [Patch v2 12/23] ACPI: Enforce stricter checks for address space descriptors Jiang Liu
2015-02-02 2:42 ` [Patch v2 13/23] ACPI: Return translation offset when parsing ACPI address space resources Jiang Liu
2015-02-02 2:42 ` [Patch v2 14/23] ACPI: Translate resource into master side address for bridge window resources Jiang Liu
2015-02-02 2:43 ` [Patch v2 15/23] ACPI: Add field offset to struct resource_list_entry Jiang Liu
2015-02-02 2:43 ` [Patch v2 16/23] ACPI: Introduce helper function acpi_dev_filter_resource_type() Jiang Liu
2015-02-02 2:43 ` [Patch v2 17/23] resources: Move struct resource_list_entry from ACPI into resource core Jiang Liu
2015-02-02 2:43 ` [Patch v2 18/23] PCI: Use common resource list management code instead of private implementation Jiang Liu
2015-02-02 2:43 ` [Patch v2 19/23] x86/PCI: Fix the range check for IO resources Jiang Liu
2015-02-02 2:43 ` [Patch v2 20/23] x86/PCI/ACPI: Use common ACPI resource interfaces to simplify implementation Jiang Liu
2015-02-02 2:43 ` [Patch v2 21/23] x86/PCI: Refine the way to release PCI IRQ resources Jiang Liu
2015-02-03 21:57 ` Rafael J. Wysocki
2015-02-04 8:35 ` [Patch v3] " Jiang Liu
2015-02-04 13:26 ` Rafael J. Wysocki
2015-02-02 2:43 ` [Patch v2 22/23] ACPI: Add interfaces to parse IOAPIC ID for IOAPIC hotplug Jiang Liu
2015-02-02 2:43 ` [Patch v2 23/23] x86/irq, ACPI: Implement ACPI driver to support " Jiang Liu
2015-02-02 3:15 ` [Patch v2 00/23] Improve ACPI resource parsing interfaces and enable " Jiang Liu
2015-02-03 21:54 ` Rafael J. Wysocki
2015-02-04 5:32 ` Jiang Liu
2015-02-04 13:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422844988-13854-10-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).