From: Jiang Liu <jiang.liu@linux.intel.com>
To: Joerg Roedel <joro@8bytes.org>,
David Woodhouse <dwmw2@infradead.org>,
Yann Droneaud <ydroneaud@opteya.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
iommu@lists.linux-foundation.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC Patch V1] iommu/vt-d: Fix build failure caused by incorrect Kconfig
Date: Mon, 2 Feb 2015 11:07:44 +0800 [thread overview]
Message-ID: <1422846464-14558-1-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1422713299.3030.23.camel@opteya.com>
Yann Droneaud <ydroneaud@opteya.com> reported one build failure as
below, which should be caused by incorrect Kconfig.
CC arch/ia64/kernel/pci-dma.o
../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_init':
../arch/ia64/kernel/pci-dma.c:41:3: error: implicit declaration of function 'intel_iommu_init' [-Werror=implicit-function-declaration]
intel_iommu_init();
^
../arch/ia64/kernel/pci-dma.c: In function 'pci_iommu_alloc':
../arch/ia64/kernel/pci-dma.c:103:2: error: implicit declaration of function 'detect_intel_iommu' [-Werror=implicit-function-declaration]
detect_intel_iommu();
^
It should be noted Kconfig complain with the following:
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64_DIG_VTD) selects INTEL_IOMMU which has unmet direct dependencies (IOMMU_SUPPORT && PCI_MSI && ACPI && (X86 || IA64_GENERIC))
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
Hi Yann,
Could you please help to test whether this patch fix the build
failure and the Kconfig warnings?
Thanks!
Gerry
---
drivers/iommu/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index 325188eef1c1..718a0c9f7bdc 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -89,7 +89,7 @@ config DMAR_TABLE
config INTEL_IOMMU
bool "Support for Intel IOMMU using DMA Remapping Devices"
- depends on PCI_MSI && ACPI && (X86 || IA64_GENERIC)
+ depends on PCI_MSI && ACPI && (X86 || IA64_DIG_VTD)
select IOMMU_API
select DMAR_TABLE
help
--
1.7.10.4
prev parent reply other threads:[~2015-02-02 3:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 14:08 ia64: implicit declaration of functions since change on <linux/dmar.h> Yann Droneaud
2015-02-02 3:07 ` Jiang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422846464-14558-1-git-send-email-jiang.liu@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).