From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965386AbbBDN2l (ORCPT ); Wed, 4 Feb 2015 08:28:41 -0500 Received: from mailgw01.mediatek.com ([66.228.70.111]:59790 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S933488AbbBDN2X (ORCPT ); Wed, 4 Feb 2015 08:28:23 -0500 X-Greylist: delayed 338 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Feb 2015 08:28:21 EST X-Listener-Flag: 11101 Subject: Re: [patch] irqchip: mtk-sysirq: fix an error code From: Yingjoe Chen To: Dan Carpenter CC: Thomas Gleixner , Jason Cooper , Matthias Brugger , , , , Eddie Huang In-Reply-To: <20150130082847.GB21357@mwanda> References: <20150130082847.GB21357@mwanda> Content-Type: text/plain; charset="UTF-8" Date: Wed, 4 Feb 2015 21:17:17 +0800 Message-ID: <1423055837.31210.29.camel@mtksdaap41> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-01-30 at 11:28 +0300, Dan Carpenter wrote: > "chip_data->intpol_base" used to be an ERR_PTR() but we recently changed > it to be NULL. We need to update the error code as well because > "PTR_ERR(NULL)" means success where really we want to return -ENOMEM. > > Fixes: cdb647a772e9 ('irqchip: mtk-sysirq: Get irq number from register resource size') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > index eaf0a71..22eb34c 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -144,7 +144,7 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > chip_data->intpol_base = ioremap(res.start, size); > if (!chip_data->intpol_base) { > pr_err("mtk_sysirq: unable to map sysirq register\n"); > - ret = PTR_ERR(chip_data->intpol_base); > + ret = -ENOMEM; > goto out_free; > } > Dan, Thanks for catching this. Acked-by: Yingjoe Chen I changed to use ioremap(), and remember to change the null pointer check but not the return type. Sorry for the mistake. Joe.C