From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752417AbbBJHj2 (ORCPT ); Tue, 10 Feb 2015 02:39:28 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:20377 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbbBJHjZ (ORCPT ); Tue, 10 Feb 2015 02:39:25 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-97-54d9b5188d52 Message-id: <1423553959.1327.1.camel@AMDC1943> Subject: Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs From: Krzysztof Kozlowski To: Stefan Wahren Cc: "H. Peter Anvin" , Linus Walleij , Dmitry Eremin-Solenikov , Support Opensource , Darren Hart , Robert Jarzmik , linux-pm@vger.kernel.org, Samuel Ortiz , Lee Jones , ac100@lists.launchpad.net, Cezary Jackiewicz , Russell King , patches@opensource.wolfsonmicro.com, Milo Kim , David Herrmann , devel@driverdev.osuosl.org, Len Brown , linux-acpi@vger.kernel.org, Ingo Molnar , linux-input@vger.kernel.org, "Rafael J. Wysocki" , linux-tegra@vger.kernel.org, Daniel Mack , platform-driver-x86@vger.kernel.org, Sebastian Reichel , Julian Andres Klode , linux-arm-kernel@lists.infradead.org, Marc Dietrich , David Woodhouse , Jiri Kosina , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, x86@kernel.org, Haojian Zhuang , Bartlomiej Zolnierkiewicz , Pavel Machek , Thomas Gleixner , Kyungmin Park Date: Tue, 10 Feb 2015 08:39:19 +0100 In-reply-to: <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de> References: <1422629278-12202-1-git-send-email-k.kozlowski@samsung.com> <1422629278-12202-5-git-send-email-k.kozlowski@samsung.com> <70066540.345820.1423508541546.JavaMail.open-xchange@oxbaltgw00.schlund.de> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-version: 1.0 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SV0xTYRTH8/WOXsDqtSB8KSYa1BAJ03li1MiLufqgYKoPxKgFGkbKSK8Q MCpDMbKXEqnKsEgRSKutRBmi1AGypQlYZWhAMYQNKhJFKfWBt9/55/c/5+UwhDiFkjBhkefl ykiZwoW2JduWmk0euMYs9e4e3QFZHdMCeHRLR0FZSzoJyX/GSMgbmSKgoX1RCGqTI6SVekPu g3wCrqh1NHRr90LBIyconymmof6OmoSO5HEhDH1/jaD28wQNN35rBKBpzEagH+6lwDz7gwJT 3R0a5jJfIUidV9Hw0SSC1K5SBJpFLQk9L0qWCxN/aRhofU1DVcM3AtrbeihQjdtDWzoFbfXn QV/xnoZnKe8IMOhvErDwcJg65MpdvZJBcxWzXtxg40uSy9bOUVytakDITc+c4b7k5Au5mg+7 OUOFGzcypqE4fWUqzfX3NtDcZGenkCt66889v1st5AxlCX7OAbb7g+WKsFi50uvgOdvQoaxR IjqbiSv66ZyImug0ZMNgdhfuXcigrOyIuwd1y7ktI2bvI9yxdOP/MIewtjxXYLFErCeums1d aduz4djUNIQsTLM7sUFTtpI7sG44LVUvtDDB5tvhr1VsGmIYkt2GywudLGjDBuCUJN663oRw weICbdVdcV7RPcLiYHYLTso+bL26Hi/kD5JWZRM2VE8QOYhVrWqoVmmqVVoJIirRBnlMUDQf GBLh48nLIviYyBDPoKgIPbK+zvxTpH6zz4hYBrmsEfnlmKViShbLx0cYEWYIFwfRhqLlSBQs i78gV0adVcYo5LwRCRgbSSLK/CUYYKo7kwoqr08m+B89Fib9VDfrv1bxBNwDjBtbcHHrmqNH tuZJftUMjK6XNCecsrO/mLXZw7dYFu4uDv1OXXpsDggJX/cmvct95kTn9Z5F3fbfx6MTJP1R 5NK8b580cOJAX934VQWvNSrte69lxZ2222PWFY4ciJk6eTvwcqELyYfKfNwIJS/7B4szDEYY AwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote: > Hi Krzysztof, > > > Krzysztof Kozlowski hat am 30. Januar 2015 um 15:47 > > geschrieben: > > > > > > Replace direct calls to power supply function attributes with wrappers. > > Wrappers provide safe access in case of unregistering the power > > supply (e.g. by removing the driver). Replace: > > - get_property -> power_supply_get_property > > - set_property -> power_supply_set_property > > - property_is_writeable -> power_supply_property_is_writeable > > > > Signed-off-by: Krzysztof Kozlowski > > Acked-by: Jonghwa Lee > > just a nit. It looks like a typo in the mail address which is also in patch 5 - > 10. Right, I copied it directly from Jonghwa's response. Thank you for noticing it. > > I applied patch 1 - 14 to my repo with a upcoming power driver (mxs_power) and > didn't see any problems with your patches. Great, thanks! Best regards, Krzysztof