From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755990AbbBPOqX (ORCPT ); Mon, 16 Feb 2015 09:46:23 -0500 Received: from cassm.net ([212.111.40.103]:58885 "EHLO mail.cassm.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754621AbbBPOqW (ORCPT ); Mon, 16 Feb 2015 09:46:22 -0500 Message-ID: <1424097995.4865.2.camel@cassm.net> Subject: Re: [PATCH v3 1/2] dgnc: Remove superfluous EXTRA_CFLAGS variable From: Cass May To: Dan Carpenter Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Date: Mon, 16 Feb 2015 14:46:35 +0000 In-Reply-To: <20150216091222.GX5206@mwanda> References: <1424043618-26947-1-git-send-email-cass@cassm.net> <20150216091222.GX5206@mwanda> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-16 at 12:12 +0300, Dan Carpenter wrote: > On Sun, Feb 15, 2015 at 11:40:17PM +0000, Cass May wrote: > > Clean up Makefile by removing unnecessary definition of DG_NAME. > > > > Signed-off-by: Cass May > > --- > > Having done some build tests, it seems that DG_NAME is not needed, > > but DG_PART is referenced in dgnc_mgmt.c. I have removed the former, > > and moved the latter into the appropriate header. > > Thanks! > > Don't resend; this patch is great. But next time just fold both patches > together into one patch. It's all part of the same fix really so it > falls into the "one thing per patch" rule. > > regards, > dan carpenter Shall do! Thank you for the guidance. -cass