From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbbBXEsS (ORCPT ); Mon, 23 Feb 2015 23:48:18 -0500 Received: from ozlabs.org ([103.22.144.67]:48846 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751973AbbBXEsR (ORCPT ); Mon, 23 Feb 2015 23:48:17 -0500 Message-ID: <1424753295.2318.5.camel@ellerman.id.au> Subject: Re: [PATCH 4/4] powerpc/mpic: remove unused functions From: Michael Ellerman To: Arseny Solokha Cc: Benjamin Herrenschmidt , Paul Mackerras , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Tue, 24 Feb 2015 15:48:15 +1100 In-Reply-To: <87a909xkji.fsf@KB00016249.iskra.kb> References: <1424084188-17097-1-git-send-email-asolokha@kb.kras.ru> <1424084188-17097-5-git-send-email-asolokha@kb.kras.ru> <1424307520.22020.5.camel@ellerman.id.au> <87d256kry8.fsf@KB00016249.iskra.kb> <1424403272.26444.1.camel@ellerman.id.au> <87a909xkji.fsf@KB00016249.iskra.kb> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-02-20 at 11:40 +0700, Arseny Solokha wrote: > > If I just get a patch saying "removed unused foo()", I have to go and dig and > > find out: > > - was it recently added and will be used soon? > > - is it ancient and never used, if so can we work out why, ie. feature X > > never landed so this code is no longer needed. > > - is it old code that *was* used but isn't now because commit ... removed the > > last user. > > - is it code that *should* be used, but isn't for some odd reason? > > > > > > So if you can provide that sort of detail for me, that really adds value to the > > patch. Otherwise the patch is basically just a TODO for me, to go and work out > > why the code is unused. > > Got it. Will resend the whole series one of these days. Thanks. cheers