From: Murali Karicheri <m-karicheri2@ti.com>
To: <davem@davemloft.net>, <mugunthanvnm@ti.com>,
<george.cherian@ti.com>, <prabhakar.csengg@gmail.com>,
<varkabhadram@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <tony@atomide.com>,
<grygorii.strashko@ti.com>, <lokeshvutla@ti.com>,
<mpa@pengutronix.de>, <w-kwok2@ti.com>
Cc: Murali Karicheri <m-karicheri2@ti.com>
Subject: [PATCH net-next 1/2] net: davinci_mdio: don't request io address range
Date: Tue, 24 Feb 2015 16:27:30 -0500 [thread overview]
Message-ID: <1424813251-31610-1-git-send-email-m-karicheri2@ti.com> (raw)
From: Grygorii Strashko <grygorii.strashko@ti.com>
Historically Davinci MDIO driver was created with assumption that
MDIO is standalone device, but for Keystone 2 it's a part
of NETCP module and now NETCP driver requests IO range which
includes MDIO IO range too. This causes Keystone 2 networking stack
failure during the boot.
"netcp-1.0 2620110.netcp: Probe of module(netcp-gbe) failed with -16"
Hence, don't request io address range from Davinci MDIO driver and
just remap it.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
drivers/net/ethernet/ti/davinci_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 98655b4..b13ec82 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -371,7 +371,7 @@ static int davinci_mdio_probe(struct platform_device *pdev)
spin_lock_init(&data->lock);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- data->regs = devm_ioremap_resource(dev, res);
+ data->regs = devm_ioremap_nocache(dev, res->start, resource_size(res));
if (IS_ERR(data->regs)) {
ret = PTR_ERR(data->regs);
goto bail_out;
--
1.7.9.5
next reply other threads:[~2015-02-24 21:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 21:27 Murali Karicheri [this message]
2015-02-24 21:27 ` [PATCH net-next 2/2] net: netcp: select davinci_mdio driver by default Murali Karicheri
2015-02-27 16:29 ` Tony Lindgren
2015-02-27 20:56 ` Murali Karicheri
2015-03-02 16:11 ` Tony Lindgren
2015-03-02 21:45 ` Murali Karicheri
2015-03-03 0:04 ` Tony Lindgren
2015-03-11 16:18 ` Murali Karicheri
2015-02-27 15:55 ` [PATCH net-next 1/2] net: davinci_mdio: don't request io address range Lad, Prabhakar
2015-02-27 16:51 ` Tony Lindgren
2015-03-11 16:35 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424813251-31610-1-git-send-email-m-karicheri2@ti.com \
--to=m-karicheri2@ti.com \
--cc=davem@davemloft.net \
--cc=george.cherian@ti.com \
--cc=grygorii.strashko@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mpa@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=prabhakar.csengg@gmail.com \
--cc=tony@atomide.com \
--cc=varkabhadram@gmail.com \
--cc=w-kwok2@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).