From: Lars Persson <lars.persson@axis.com>
To: linux-mips@linux-mips.org, ralf@linux-mips.org, paul.burton@imgtec.com
Cc: linux-kernel@vger.kernel.org, Lars Persson <larper@axis.com>
Subject: [PATCH 0/2] New fix for icache coherency race
Date: Thu, 26 Feb 2015 14:16:01 +0100 [thread overview]
Message-ID: <1424956563-29535-1-git-send-email-larper@axis.com> (raw)
This patch set proposes an improved fix for the race condition that
originally was fixed in commit 2a4a8b1e5d9d ("MIPS: Remove race window
in page fault handling").
I have used the flush_icache_page API that is marked as deprecated in
Documentation/cachetlb.txt. There are strong reasons to keep this API
because it is not possible to implement an efficient and race-free
lazy flushing using the other APIs.
You can refer to a discussion about the same issue in arch/arm where
they chose to implement the solution in set_pte_at. In arch/mips we
could not do this because we lack information about the executability
of the mapping in set_pte_at() and thus we would have to flush all
pages to be safe.
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-November/030915.html
Lars Persson (2):
Revert "MIPS: Remove race window in page fault handling"
MIPS: Fix race condition in lazy cache flushing.
arch/mips/include/asm/cacheflush.h | 35 ++++++++++++++++++++---------------
arch/mips/include/asm/pgtable.h | 10 ++++++----
arch/mips/mm/cache.c | 27 ++++++++-------------------
3 files changed, 34 insertions(+), 38 deletions(-)
--
1.7.10.4
next reply other threads:[~2015-02-26 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 13:16 Lars Persson [this message]
2015-02-26 13:16 ` [PATCH 1/2] Revert "MIPS: Remove race window in page fault handling" Lars Persson
2015-02-26 13:16 ` [PATCH 2/2] MIPS: Fix race condition in lazy cache flushing Lars Persson
2015-04-08 22:53 ` [PATCH 0/2] New fix for icache coherency race Paul Burton
2015-04-09 10:54 ` Lars Persson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424956563-29535-1-git-send-email-larper@axis.com \
--to=lars.persson@axis.com \
--cc=larper@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).