From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754686AbbCFXBE (ORCPT ); Fri, 6 Mar 2015 18:01:04 -0500 Received: from gate.crashing.org ([63.228.1.57]:57582 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754374AbbCFXBC (ORCPT ); Fri, 6 Mar 2015 18:01:02 -0500 Message-ID: <1425682582.4636.197.camel@kernel.crashing.org> Subject: Re: [REGRESSION in 3.18][PPC] PA Semi fails to boot after: of/base: Fix PowerPC address parsing hack From: Benjamin Herrenschmidt To: Steven Rostedt Cc: LKML , Grant Likely , Rob Herring , Olof Johansson , linuxppc-dev@lists.ozlabs.org Date: Sat, 07 Mar 2015 09:56:22 +1100 In-Reply-To: <20150306100021.5637d790@gandalf.local.home> References: <20150305171239.3a8135e6@gandalf.local.home> <1425615522.4636.173.camel@kernel.crashing.org> <20150306100021.5637d790@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-06 at 10:00 -0500, Steven Rostedt wrote: > On Fri, 06 Mar 2015 15:18:42 +1100 > Benjamin Herrenschmidt wrote: > > > > Can you shoot me the DT (/proc/device-tree in a tarball) ? > > Attached. This is indeed a bug in their DT. We might want to add quirks for that unless it can be fixed (or has been via FW update). Olof ? In the meantime, try that patch: diff --git a/drivers/of/address.c b/drivers/of/address.c index ad29069..78a7dcb 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -450,12 +450,17 @@ static struct of_bus *of_match_bus(struct device_node *np) return NULL; } -static int of_empty_ranges_quirk(void) +static int of_empty_ranges_quirk(struct device_node *np) { if (IS_ENABLED(CONFIG_PPC)) { - /* To save cycles, we cache the result */ + /* To save cycles, we cache the result for global "Mac" setting */ static int quirk_state = -1; + /* PA-SEMI sdc DT bug */ + if (of_device_is_compatible(np, "1682m-sdc")) + return true; + + /* Make quirk cached */ if (quirk_state < 0) quirk_state = of_machine_is_compatible("Power Macintosh") || @@ -490,7 +495,7 @@ static int of_translate_one(struct device_node *parent, struct of_bus *bus, * This code is only enabled on powerpc. --gcl */ ranges = of_get_property(parent, rprop, &rlen); - if (ranges == NULL && !of_empty_ranges_quirk()) { + if (ranges == NULL && !of_empty_ranges_quirk(parent)) { pr_debug("OF: no ranges; cannot translate\n"); return 1; }